wrong icons parameter value in manifest.json for chrome buildtool fix.

packagerChrome.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus build tools,
 # Copyright (C) 2006-2014 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 55 matching lines @@
 
   if metadata.has_option('general', 'browserAction') and metadata.get('general', 'browserAction') != '':
     if re.search(r'\s+', metadata.get('general', 'browserAction')):
       icon, popup = re.split(r'\s+', metadata.get('general', 'browserAction'), 1)
     else:
       icon, popup = (metadata.get('general', 'browserAction'), None)
     templateData['browserAction'] = {'icon': icon, 'popup': popup}
 
   if metadata.has_option('general', 'icons'):
     icons = {}
-    iconsDir = baseDir
-    for dir in metadata.get('general', 'icons').split('/')[0:-1]:
-      iconsDir = os.path.join(iconsDir, dir)
-
-    prefix, suffix = metadata.get('general', 'icons').split('/')[-1].split('?', 1)
-    for file in os.listdir(iconsDir):
-      path = os.path.join(iconsDir, file)
-      if os.path.isfile(path) and file.startswith(prefix) and file.endswith(suffix):
-        size = file[len(prefix):-len(suffix)]
-        if not re.search(r'\D', size):
-          icons[size] = os.path.relpath(path, baseDir).replace('\\', '/')
-
+    for icon in re.split('\s+', metadata.get('general', 'icons')):
+      match = re.search("\d+(?=\.)", icon)

[Wladimir Palant, 2014/03/18 17:22:50]

Determining icon size that way is even more a hack than the original approach.

We use PIL in imageConversion.py already, we can use Image.size to determine
icon size (http://effbot.org/imagingbook/image.htm#image-size-attribute). The
simplest approach should be using the image width and showing a warning if the
icon isn't square.

[saroyanm, 2014/03/19 09:04:35]

Good point, thanks for pointing.
Updated.

+      if match:
+        value = match.group()
+        icons[value] = icon
     templateData['icons'] = icons
 
   if metadata.has_option('general', 'permissions'):
     templateData['permissions'] = re.split(r'\s+', metadata.get('general', 'permissions'))
     if params['experimentalAPI']:
       templateData['permissions'].append('experimental')
 
   if metadata.has_option('general', 'backgroundScripts'):
     templateData['backgroundScripts'] = re.split(r'\s+', metadata.get('general', 'backgroundScripts'))
     if params['devenv']:
@@ skipping 311 matching lines @@
   def shutdown_server(server):
     time.sleep(10)
     server.shutdown()
   thread.start_new_thread(shutdown_server, (server,))
   server.serve_forever()
 
   if connections[0] == 0:
     print 'Warning: No incoming connections, extension probably not active in the browser yet'
   else:
     print 'Handled %i connection(s)' % connections[0]