wrong icons parameter value in manifest.json for chrome buildtool fix.

This fix is related to current ticket: https://issues.adblockplus.org/ticket/156

Relative review:
http://codereview.adblockplus.org/5676337998069760

[saroyanm, 2014-03-18 16:19:41]

@Wladimir Can you please have a look on this review when you will have time,
Thanks in advance.

[Wladimir Palant, 2014-03-18 17:22:50]

http://codereview.adblockplus.org/5406295150559232/diff/5629499534213120/pack...
File packagerChrome.py (right):

http://codereview.adblockplus.org/5406295150559232/diff/5629499534213120/pack...
packagerChrome.py:77: match = re.search("\d+(?=\.)", icon)
Determining icon size that way is even more a hack than the original approach.

We use PIL in imageConversion.py already, we can use Image.size to determine
icon size (http://effbot.org/imagingbook/image.htm#image-size-attribute). The
simplest approach should be using the image width and showing a warning if the
icon isn't square.

[saroyanm, 2014-03-19 09:04:35]

New patch uploaded.

http://codereview.adblockplus.org/5406295150559232/diff/5629499534213120/pack...
File packagerChrome.py (right):

http://codereview.adblockplus.org/5406295150559232/diff/5629499534213120/pack...
packagerChrome.py:77: match = re.search("\d+(?=\.)", icon)
On 2014/03/18 17:22:50, Wladimir Palant wrote:
> Determining icon size that way is even more a hack than the original approach.
> 
> We use PIL in imageConversion.py already, we can use Image.size to determine
> icon size (http://effbot.org/imagingbook/image.htm#image-size-attribute). The
> simplest approach should be using the image width and showing a warning if the
> icon isn't square.

Good point, thanks for pointing.
Updated.

[Wladimir Palant, 2014-03-19 12:11:48]

http://codereview.adblockplus.org/5406295150559232/diff/5685265389584384/imag...
File imageConversion.py (right):

http://codereview.adblockplus.org/5406295150559232/diff/5685265389584384/imag...
imageConversion.py:138: return Image.open(StringIO(file)).size
I didn't mean to actually put this code into imageConversion - it doesn't belong
here, unrelated to image conversions. You should simply use PIL in
packagerChrome instead.

http://codereview.adblockplus.org/5406295150559232/diff/5685265389584384/pack...
File packagerChrome.py (right):

http://codereview.adblockplus.org/5406295150559232/diff/5685265389584384/pack...
packagerChrome.py:78: iconSize = getImageSize(files[icon])
Please use destructuring assignment here, that's easier to read:

  width, height = getImageSize(files[icon])

[saroyanm, 2014-03-19 14:54:18]

Thanks for your notes Wladimir,
Please have a look on last uploaded patch set.

http://codereview.adblockplus.org/5406295150559232/diff/5685265389584384/imag...
File imageConversion.py (right):

http://codereview.adblockplus.org/5406295150559232/diff/5685265389584384/imag...
imageConversion.py:138: return Image.open(StringIO(file)).size
On 2014/03/19 12:11:48, Wladimir Palant wrote:
> I didn't mean to actually put this code into imageConversion - it doesn't
belong
> here, unrelated to image conversions. You should simply use PIL in
> packagerChrome instead.

Got it, 
moved to packager.

http://codereview.adblockplus.org/5406295150559232/diff/5685265389584384/pack...
File packagerChrome.py (right):

http://codereview.adblockplus.org/5406295150559232/diff/5685265389584384/pack...
packagerChrome.py:78: iconSize = getImageSize(files[icon])
On 2014/03/19 12:11:48, Wladimir Palant wrote:
> Please use destructuring assignment here, that's easier to read:
> 
>   width, height = getImageSize(files[icon])

Done.

[Wladimir Palant, 2014-03-19 21:23:06]

LGTM with the remaining issue addressed.

http://codereview.adblockplus.org/5406295150559232/diff/5076324926357504/pack...
File packagerChrome.py (right):

http://codereview.adblockplus.org/5406295150559232/diff/5076324926357504/pack...
packagerChrome.py:80: print 'Warning: %s size is %ix%i, icon should be square' %
(icon, width, height)
Errors and warnings should go to stderr:

  print >>sys.stderr, ...

[saroyanm, 2014-03-20 07:03:55]

On 2014/03/19 21:23:06, Wladimir Palant wrote:
> LGTM with the remaining issue addressed.
> 
>
http://codereview.adblockplus.org/5406295150559232/diff/5076324926357504/pack...
> File packagerChrome.py (right):
> 
>
http://codereview.adblockplus.org/5406295150559232/diff/5076324926357504/pack...
> packagerChrome.py:80: print 'Warning: %s size is %ix%i, icon should be square'
%
> (icon, width, height)
> Errors and warnings should go to stderr:
> 
>   print >>sys.stderr, ...

Changes pushed,
Thanks.