wrong icons parameter value in manifest.json for chrome buildtool fix.

packagerChrome.py

 # coding: utf-8
 
 # This file is part of the Adblock Plus build tools,
 # Copyright (C) 2006-2014 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
@@ skipping 32 matching lines @@
   for file in os.listdir(baseDir):
     if file.endswith('.js') or file.endswith('.html') or file.endswith('.xml'):
       result.add(file)
   return result
 
 def processFile(path, data, params):
   # We don't change anything yet, this function currently only exists here so
   # that it can be overridden if necessary.
   return data
 
-def createManifest(params):
+def createManifest(params, files):
   template = getTemplate('manifest.json.tmpl')
   templateData = dict(params)
 
   baseDir = templateData['baseDir']
   metadata = templateData['metadata']
 
   if metadata.has_option('general', 'pageAction') and metadata.get('general', 'pageAction') != '':
     if re.search(r'\s+', metadata.get('general', 'pageAction')):
       icon, popup = re.split(r'\s+', metadata.get('general', 'pageAction'), 1)
     else:
       icon, popup = (metadata.get('general', 'pageAction'), None)
     templateData['pageAction'] = {'icon': icon, 'popup': popup}
 
   if metadata.has_option('general', 'browserAction') and metadata.get('general', 'browserAction') != '':
     if re.search(r'\s+', metadata.get('general', 'browserAction')):
       icon, popup = re.split(r'\s+', metadata.get('general', 'browserAction'), 1)
     else:
       icon, popup = (metadata.get('general', 'browserAction'), None)
     templateData['browserAction'] = {'icon': icon, 'popup': popup}
 
   if metadata.has_option('general', 'icons'):
+    from PIL import Image
     icons = {}
     for icon in re.split('\s+', metadata.get('general', 'icons')):
-      match = re.search("\d+(?=\.)", icon)

[Wladimir Palant, 2014/03/18 17:22:50]

Determining icon size that way is even more a hack than the original approach.

We use PIL in imageConversion.py already, we can use Image.size to determine
icon size (http://effbot.org/imagingbook/image.htm#image-size-attribute). The
simplest approach should be using the image width and showing a warning if the
icon isn't square.

[saroyanm, 2014/03/19 09:04:35]

Good point, thanks for pointing.
Updated.

-      if match:
-        value = match.group()
-        icons[value] = icon
+      width, height = Image.open(StringIO(files[icon])).size
+      if(width != height):
+        print 'Warning: %s size is %ix%i, icon should be square' % (icon, width, height)

[Wladimir Palant, 2014/03/19 21:23:06]

Errors and warnings should go to stderr:

  print >>sys.stderr, ...

+      icons[width] = icon
     templateData['icons'] = icons
 
   if metadata.has_option('general', 'permissions'):
     templateData['permissions'] = re.split(r'\s+', metadata.get('general', 'permissions'))
     if params['experimentalAPI']:
       templateData['permissions'].append('experimental')
 
   if metadata.has_option('general', 'backgroundScripts'):
     templateData['backgroundScripts'] = re.split(r'\s+', metadata.get('general', 'backgroundScripts'))
     if params['devenv']:
@@ skipping 240 matching lines @@
     'baseDir': baseDir,
     'releaseBuild': releaseBuild,
     'version': version,
     'experimentalAPI': experimentalAPI,
     'devenv': devenv,
     'metadata': metadata,
   }
 
   files = Files(getPackageFiles(params), getIgnoredFiles(params),
                 process=lambda path, data: processFile(path, data, params))
-  files['manifest.json'] = createManifest(params)
+  
   if metadata.has_section('mapping'):
     files.readMappedFiles(metadata.items('mapping'))
   files.read(baseDir)
 
   if metadata.has_section('convert_js'):
     convertJS(params, files)
 
   if metadata.has_section('convert_img'):
     from imageConversion import convertImages
     convertImages(params, files)
 
   if metadata.has_section('preprocess'):
     files.preprocess(
       [f for f, _ in metadata.items('preprocess')],
       {'needsExt': True}
     )
 
   if metadata.has_section('import_locales'):
     importGeckoLocales(params, files)
-
+  
+  files['manifest.json'] = createManifest(params, files)
   fixMissingTranslations(files)
 
   if devenv:
     files['devenvPoller__.js'] = createPoller(params)
 
   if (metadata.has_option('general', 'backgroundScripts') and
       'lib/info.js' in re.split(r'\s+', metadata.get('general', 'backgroundScripts')) and
       'lib/info.js' not in files):
     files['lib/info.js'] = createInfoModule(params)
 
@@ skipping 30 matching lines @@
   def shutdown_server(server):
     time.sleep(10)
     server.shutdown()
   thread.start_new_thread(shutdown_server, (server,))
   server.serve_forever()
 
   if connections[0] == 0:
     print 'Warning: No incoming connections, extension probably not active in the browser yet'
   else:
     print 'Handled %i connection(s)' % connections[0]