Issue 5420918314631168: Issue 1372 - Work around a bug in Chrome 38 where 'object' requests have the wrong type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5420918314631168: Issue 1372 - Work around a bug in Chrome 38 where 'object' requests have the wrong type (Closed)

Created:
Sept. 25, 2014, 2:53 p.m. by Sebastian Noack

Modified:
Sept. 25, 2014, 4:29 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

Issue 1372 - Work around a bug in Chrome 38 where 'object' requests have the wrong type

Patch Set 1 #

Total comments: 3

Created: Sept. 25, 2014, 2:53 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	chrome/ext/background.js	View		2 chunks	+15 lines, -4 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Sebastian Noack

http://codereview.adblockplus.org/5420918314631168/diff/5629499534213120/chrome/ext/background.js File chrome/ext/background.js (right): http://codereview.adblockplus.org/5420918314631168/diff/5629499534213120/chrome/ext/background.js#newcode325 chrome/ext/background.js:325: if (requestType == "other" && / Chrome\/38\b/.test(navigator.userAgent)) Just in ...

Sept. 25, 2014, 3 p.m. (2014-09-25 15:00:52 UTC) #1

Wladimir Palant

Sept. 25, 2014, 4:18 p.m. (2014-09-25 16:18:16 UTC) #2

Sebastian Noack

Sept. 25, 2014, 4:24 p.m. (2014-09-25 16:24:05 UTC) #4

http://codereview.adblockplus.org/5420918314631168/diff/5629499534213120/chro...
File chrome/ext/background.js (right):

http://codereview.adblockplus.org/5420918314631168/diff/5629499534213120/chro...
chrome/ext/background.js:325: if (requestType == "other" && /
Chrome\/38\b/.test(navigator.userAgent))
On 2014/09/25 16:18:16, Wladimir Palant wrote:
> I wonder whether we should really do this for Chrome 38 only - as opposed to
> Chrome 38 and above. Well, there is always hope that this will simply be
> fixed...

In case this isn't fixed in Chrome 39, this workaround won't do any good anyway.
Note that in Chrome 39 Canary build almost everything is reported with type
"others".

Expand All Messages | Collapse All Messages