Issue 1086 - Add acceptable ads checkbox to the settings page

html/static/js/IESettings.js

 function init()
 {
   try
   {
     initLanguageSettings();
    
     initDomainSettings();
   }
   catch (err)
   {
-    //alert("err: " + err);
+//    alert("err: " + err);

[Felix Dahlke, 2014/07/22 14:28:10]

That change seems unrelated :D

   }
 }
 
 function setElementText(id, key)
 {
   var el = document.getElementById(id);
   if (el)
   {
     var text = UserSettings().GetMessage("settings", key);
     if (text)
     {
       el.innerText = text; 
     }
   }
 }
 
+function acceptableAdsChange()
+{
+  var aaCheckbox = document.getElementById("acceptableAdsCheckbox");
+  UserSettings().SetAcceptableAdsEnabled(aaCheckbox.checked);  
+}
+
 function initLanguageSettings()
 {
   setElementText("title", "settings-title");
 
   setElementText("localeLanguageLabel", "settings-language-label");
   setElementText("localeLanguageDescription", "settings-language-description");
 
   setElementText("localeBlockingLabel", "settings-blocking-label");
   setElementText("localeBlockingDescription", "settings-blocking-description");
 
   setElementText("manageExceptions", "settings-exceptions-manage-label");
   setElementText("addDomain", "settings-exceptions-add-label");
   setElementText("removeDomains", "settings-exceptions-remove-label");
 
   setElementText("localeWorthSharing", "settings-share-label");
+
+  setElementText("acceptableAdsLabel", "settings-acceptable-ads");
    
+  var aaCheckbox = document.getElementById("acceptableAdsCheckbox");
+  if (aaCheckbox)
+  {
+    aaCheckbox.checked = UserSettings().IsAcceptableAdsEnabled();
+    addListener(aaCheckbox, "change", acceptableAdsChange, false);
+  }
+
   var optionsLanguage = document.getElementById("language");
 
   var languageCount = UserSettings().GetLanguageCount();
   for(var i = 0; i < languageCount; i++)
   {
     var el = document.createElement("option");
     el.text = UserSettings().GetLanguageTitleByIndex(i);
     el.value = UserSettings().GetLanguageByIndex(i);
     
     optionsLanguage.add(el, 0);
@@ skipping 86 matching lines @@
     for (var i = removeOptions.length; i--;)
     {
       optionsDomain.remove(removeOptions[i]);
     }
   }, false);
 }
 
 window.UserSettings = function()
 {
   return window.Settings;
-}
+}

[Felix Dahlke, 2014/07/22 14:28:10]

Was this a missing EOF? If so let's keep it.