Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5427527162003456: Issue 1086 - Add acceptable ads checkbox to the settings page (Closed)

Created:
July 21, 2014, 11:42 a.m. by Oleksandr
Modified:
July 23, 2014, 7:03 a.m.
Reviewers:
sergei, Felix Dahlke, Eric
Visibility:
Public.

Description

Issue 1086 - Add acceptable ads checkbox to the settings page

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved from onchange in html to addListener in JS #

Total comments: 2

Patch Set 3 : Cosmetic fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -34 lines) Patch
M html/static/js/IESettings.js View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M html/templates/index.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M locales/en.ini View 2 chunks +2 lines, -2 lines 0 comments Download
M locales/uk.ini View 2 chunks +2 lines, -2 lines 0 comments Download
M src/plugin/AdblockPlus.rc View 1 chunk +0 lines, -1 line 0 comments Download
M src/plugin/PluginClass.cpp View 2 chunks +0 lines, -27 lines 0 comments Download
M src/plugin/PluginUserSettings.cpp View 2 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Oleksandr
July 21, 2014, 11:44 a.m. (2014-07-21 11:44:21 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/5427527162003456/diff/5629499534213120/html/templates/index.html File html/templates/index.html (right): http://codereview.adblockplus.org/5427527162003456/diff/5629499534213120/html/templates/index.html#newcode39 html/templates/index.html:39: <input type="checkbox" id="acceptableAdsCheckbox" onchange="acceptableAdsChange(this)"/><label id="acceptableAdsLabel" for="acceptableAdsCheckbox">Enable some non-intrusive advertising</label> ...
July 21, 2014, 1:15 p.m. (2014-07-21 13:15:36 UTC) #2
Oleksandr
July 22, 2014, 2:24 p.m. (2014-07-22 14:24:18 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/5427527162003456/diff/5639274879778816/html/static/js/IESettings.js File html/static/js/IESettings.js (right): http://codereview.adblockplus.org/5427527162003456/diff/5639274879778816/html/static/js/IESettings.js#newcode11 html/static/js/IESettings.js:11: // alert("err: " + err); That change seems unrelated ...
July 22, 2014, 2:28 p.m. (2014-07-22 14:28:10 UTC) #4
Oleksandr
July 22, 2014, 3:57 p.m. (2014-07-22 15:57:30 UTC) #5
Felix Dahlke
July 23, 2014, 5:16 a.m. (2014-07-23 05:16:59 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld