Automatically enable acceptable ads and notify the user about it

This is based on the changes in this review:
http://codereview.adblockplus.org/6196972490850304/

[Wladimir Palant, 2013-11-26 11:01:02]

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/jni/...
File jni/abpEngine.cpp (right):

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/jni/...
jni/abpEngine.cpp:475: filterEngine->SetPref("notified_about_acceptable_ads",
jsEngine->NewValue(notified));
This won't do anything, prefs that aren't defined won't persist.

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/src/...
File src/org/adblockplus/android/Preferences.java (right):

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/src/...
src/org/adblockplus/android/Preferences.java:162: else if
(!application.isNotifiedAboutAcceptableAds())
Shouldn't you check whether acceptable ads are already enabled, just to be safe?

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/src/...
src/org/adblockplus/android/Preferences.java:165:
getString(R.string.msg_acceptable_ads), application.getAcceptableAdsUrl());
Style nit: add a line break to put the last parameter on a separate line?

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/src/...
src/org/adblockplus/android/Preferences.java:215:
.replaceAll("&lt;a&gt;(.*?)&lt;/a&gt;", "<a href=\"" + url + "\">$1</a>");
Comment from previous review (encode entities in URL) applies here as well.

[Felix Dahlke, 2013-11-26 13:59:31]

Fixed the prefs and url encode issues, commented on the others.

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/jni/...
File jni/abpEngine.cpp (right):

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/jni/...
jni/abpEngine.cpp:475: filterEngine->SetPref("notified_about_acceptable_ads",
jsEngine->NewValue(notified));
On 2013/11/26 11:01:02, Wladimir Palant wrote:
> This won't do anything, prefs that aren't defined won't persist.

Done. Wasn't aware of that. IMO, it doesn't make sense to have this pref in
libadblockplus, so I used the Android preference API instead.

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/src/...
File src/org/adblockplus/android/Preferences.java (right):

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/src/...
src/org/adblockplus/android/Preferences.java:162: else if
(!application.isNotifiedAboutAcceptableAds())
On 2013/11/26 11:01:02, Wladimir Palant wrote:
> Shouldn't you check whether acceptable ads are already enabled, just to be
safe?

Why? Even if they were, we want to notify every user at least once about them.

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/src/...
src/org/adblockplus/android/Preferences.java:165:
getString(R.string.msg_acceptable_ads), application.getAcceptableAdsUrl());
On 2013/11/26 11:01:02, Wladimir Palant wrote:
> Style nit: add a line break to put the last parameter on a separate line?

I'm wrapping Java code to 100 columns currently, as suggested by the Mozilla
Java style guide.

http://codereview.adblockplus.org/5431458994847744/diff/5629499534213120/src/...
src/org/adblockplus/android/Preferences.java:215:
.replaceAll("&lt;a&gt;(.*?)&lt;/a&gt;", "<a href=\"" + url + "\">$1</a>");
On 2013/11/26 11:01:02, Wladimir Palant wrote:
> Comment from previous review (encode entities in URL) applies here as well.

Done.

[Wladimir Palant, 2013-11-26 15:13:32]

LGTM