Issue 5440712837431296: Add label for ToolbarItems in Safari during build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5440712837431296: Add label for ToolbarItems in Safari during build (Closed)

Created:
Jan. 15, 2014, 3:23 p.m. by Sebastian Noack

Modified:
Jan. 15, 2014, 4:11 p.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

The label shown when customizing the toolbar can't be set at runtime. So we have to set the label at build-time. However we still update the label, shown in the tooltip and when the toolbar is collapsed, at runtime in order to have them translated. This patchset only contains the changes for adblockpluschrome. For the changes regarding the buildtools see http://codereview.adblockplus.org/6003662790852608.

Patch Set 1 #

Created: Jan. 15, 2014, 3:23 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	.hgsubstate	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	metadata.safari	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages