Issue 417 - Reinitializing removed filter lists (Core/Firefox)

Although #417 is Chrome-specific I also included the code for Firefox to handle cases in which patterns.ini is empty and no backups exist. This is not required though so let me know if you think this shouldn't be implemented for Firefox.

[Thomas Greiner, 2014-05-26 13:33:04]

Although #417 is Chrome-specific I also included the code for Firefox to handle
cases in which patterns.ini is empty and no backups exist. This is not required
though so let me know if you think this shouldn't be implemented for Firefox.

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chro...
File chrome/locale/en-US/firstRun.properties (right):

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chro...
chrome/locale/en-US/firstRun.properties:6:
firstRun_filterlistsReinitializedWarning=We detected an issue causing all
filters to be removed and we were unable to restore a backup. Therefore we had
to reset your filters and Acceptable Ads settings. Please check your filter
lists and Acceptable Ads settings in the <a>options page</a>.
Any feedback on this text is very much appreciated.

[Wladimir Palant, 2014-05-26 15:08:46]

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chro...
File chrome/locale/en-US/firstRun.properties (right):

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chro...
chrome/locale/en-US/firstRun.properties:6:
firstRun_filterlistsReinitializedWarning=We detected an issue causing all
filters to be removed and we were unable to restore a backup. Therefore we had
to reset your filters and Acceptable Ads settings. Please check your filter
lists and Acceptable Ads settings in the <a>options page</a>.
On 2014/05/26 13:33:05, Thomas Greiner wrote:
> Any feedback on this text is very much appreciated.

Firefox currently doesn't have an options page - please say "in the Adblock Plus
options" instead.

Also, "We detected an issue causing all filters to be removed" is wrong - we
didn't detect anything, we merely suspect. How about: "It seems that an issue
caused all filters to be removed"

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/lib/...
File lib/filterListener.js (right):

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/lib/...
lib/filterListener.js:138: });
This is really the wrong place to do it. We are already running first-run
actions in Firefox from the UI module, whenever the version number changes -
that's where we already check whether filters and subscriptions got lost. If
anything, you might override the version number check for the
FilterStorage.subscriptions.length == 0 scenario.

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/lib/...
File lib/filterStorage.js (right):

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/lib/...
lib/filterStorage.js:411: }
This callback is unnecessary and actually harmful since the "load" notification
isn't being triggered meaning that some initialization code will never run. Any
code can listen to the "load" notification and see for itself whether the data
loaded is empty.

[Thomas Greiner, 2014-05-26 17:45:38]

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chro...
File chrome/locale/en-US/firstRun.properties (right):

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/chro...
chrome/locale/en-US/firstRun.properties:6:
firstRun_filterlistsReinitializedWarning=We detected an issue causing all
filters to be removed and we were unable to restore a backup. Therefore we had
to reset your filters and Acceptable Ads settings. Please check your filter
lists and Acceptable Ads settings in the <a>options page</a>.
On 2014/05/26 15:08:46, Wladimir Palant wrote:
> On 2014/05/26 13:33:05, Thomas Greiner wrote:
> > Any feedback on this text is very much appreciated.
> 
> Firefox currently doesn't have an options page - please say "in the Adblock
Plus
> options" instead.
> 
> Also, "We detected an issue causing all filters to be removed" is wrong - we
> didn't detect anything, we merely suspect. How about: "It seems that an issue
> caused all filters to be removed"

Done.

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/lib/...
File lib/filterListener.js (right):

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/lib/...
lib/filterListener.js:138: });
On 2014/05/26 15:08:46, Wladimir Palant wrote:
> This is really the wrong place to do it. We are already running first-run
> actions in Firefox from the UI module, whenever the version number changes -
> that's where we already check whether filters and subscriptions got lost. If
> anything, you might override the version number check for the
> FilterStorage.subscriptions.length == 0 scenario.

Done.

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/lib/...
File lib/filterStorage.js (right):

http://codereview.adblockplus.org/5450822905233408/diff/5629499534213120/lib/...
lib/filterStorage.js:411: }
On 2014/05/26 15:08:46, Wladimir Palant wrote:
> This callback is unnecessary and actually harmful since the "load"
notification
> isn't being triggered meaning that some initialization code will never run.
Any
> code can listen to the "load" notification and see for itself whether the data
> loaded is empty.

Done.

[Wladimir Palant, 2014-05-27 06:44:41]

LGTM