Issue 417 - Reinitializing removed filter lists (Core/Firefox)

lib/filterListener.js

Index: lib/filterListener.js
===================================================================
--- a/lib/filterListener.js
+++ b/lib/filterListener.js
@@ -120,7 +120,22 @@
     ElemHide.init();
   else
     flushElemHide = function() {};    // No global stylesheet in Chrome & Co.
-  FilterStorage.loadFromDisk();
+  FilterStorage.loadFromDisk(null, function()
+  {
+    // All attempts to restore filter settings have failed
+    // so we need to reinitialize them
+    if (addSubscription)
+    {
+      addSubscription(null);
+      filterlistsReinitialized = true;
+    }
+    else
+    {
+      let {UI} = require("ui");
+      UI.addSubscription(UI.currentWindow, null);
+      UI.filterlistsReinitialized = true;
+    }
+  });

[Wladimir Palant, 2014/05/26 15:08:46]

This is really the wrong place to do it. We are already running first-run
actions in Firefox from the UI module, whenever the version number changes -
that's where we already check whether filters and subscriptions got lost. If
anything, you might override the version number check for the
FilterStorage.subscriptions.length == 0 scenario.

[Thomas Greiner, 2014/05/26 17:45:38]

Done.

 
   TimeLine.log("done initializing data structures");