Issue 5466750908891136: Reset browser actions on Safari while the tab is loading

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5466750908891136: Reset browser actions on Safari while the tab is loading (Closed)

Created:
Jan. 23, 2014, 10:10 a.m. by Sebastian Noack

Modified:
Jan. 23, 2014, 10:36 a.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

Browser actions on Chrome are automatically reset when the tab is loading. So since we just emulate Chrome's behavior on Safari, we also have to take care of reseting browser actions, like Chrome does. This issue was causing the badge not being set to 0, when navigating from a website with blocked ads to a website without blocked ads.

Patch Set 1 #

Created: Jan. 23, 2014, 10:10 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	safari/ext/background.js	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages