Issue 1795 - Add helper std::wstring GetLocationUrl(IWebBrowser2& browser)

src/plugin/PluginUtil.h

Index: src/plugin/PluginUtil.h
diff --git a/src/plugin/PluginUtil.h b/src/plugin/PluginUtil.h
index ee8cf05ca5ebd5a7a5df0713cd13939d34e087bd..50130cb8414eee42e92a38a3db06023ea2a4ae7e 100644
--- a/src/plugin/PluginUtil.h
+++ b/src/plugin/PluginUtil.h
@@ -5,3 +5,5 @@ std::wstring HtmlFolderPath();
 std::wstring UserSettingsFileUrl();
 std::wstring FirstRunPageFileUrl();
 std::wstring FileUrl(const std::wstring& url);
+std::wstring GetLocationUrl(IWebBrowser2& browser);

[Eric, 2015/01/13 17:04:20]

I had a version of this function in the string conversion I did last summer (the
one that no one liked). Instead of a collection of loose functions all taking
IWebBrowser2 arguments, this and analogous functions were methods of a wrapper
class. Since you're already using a reference (assuming null checking is
elsewhere), there's no reason not to start off by making this a wrapper class.

[sergei, 2015/01/29 12:42:11]

Should I create the class for it?

[Eric, 2015/02/02 19:07:54]

The next time you write a function with an argument of type 'IBrowser2&', that's
the time to create a class for it and use methods. Not so much need when there's
only one loose function about.

+