Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5474511327592448: Issue 703 - Make sure that z-index of the "Block Element" dialog is the highest in the document (Closed)

Created:
June 24, 2014, 9:05 a.m. by Sebastian Noack
Modified:
Sept. 1, 2014, 10:04 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Hard-code 0x7FFFFFFF as z-index #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include.postload.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
June 24, 2014, 9:08 a.m. (2014-06-24 09:08:15 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5474511327592448/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5474511327592448/diff/5629499534213120/include.postload.js#newcode129 include.postload.js:129: )) + 1; Please just use the maximum possible ...
June 24, 2014, 10:31 a.m. (2014-06-24 10:31:39 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/5474511327592448/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/5474511327592448/diff/5629499534213120/include.postload.js#newcode129 include.postload.js:129: )) + 1; On 2014/06/24 10:31:39, Wladimir Palant wrote: ...
June 24, 2014, 1:07 p.m. (2014-06-24 13:07:52 UTC) #3
Wladimir Palant
June 24, 2014, 1:34 p.m. (2014-06-24 13:34:52 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld