Issue 2066 - Get rid of non-standard __defineGetter__, __defineSetter__, and __lookupGetter__

qunit/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 27 matching lines @@
 
 function restoreFilterComponents()
 {
 }
 
 function preparePrefs()
 {
   this._pbackup = Object.create(null);
   for (var pref in Prefs)
   {
-    if (pref != "addListener" && pref != "removeListener")

[Wladimir Palant, 2015/03/02 19:17:17]

I generally try to avoid lists that have to by kept in sync. Maybe:

  typeof Prefs[pref] != "function"

[Sebastian Noack, 2015/03/02 19:28:09]

IMO, checking for a dynamic getter was a footgun. But checking for non-functions
sounds robust enough to me.

+    if (typeof Prefs[pref] != "function")
       this._pbackup[pref] = Prefs[pref];
   }
   Prefs.enabled = true;
 }
 
 function restorePrefs()
 {
   for (var pref in this._pbackup)
     Prefs[pref] = this._pbackup[pref];
 }
 
 function executeFirstRunActions()
 {
 }