Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5485735259930624: Issue 2066 - Get rid of non-standard __defineGetter__, __defineSetter__, and __lookupGetter__ (Closed)

Created:
March 1, 2015, 12:15 p.m. by Sebastian Noack
Modified:
March 3, 2015, 8:27 a.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 2066 - Get rid of non-standard __defineGetter__, __defineSetter__, and __lookupGetter__

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -31 lines) Patch
M lib/prefs.js View 1 chunk +32 lines, -29 lines 0 comments Download
M lib/utils.js View 1 chunk +1 line, -1 line 0 comments Download
M qunit/common.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5
Sebastian Noack
March 1, 2015, 12:15 p.m. (2015-03-01 12:15:43 UTC) #1
kzar
LGTM
March 2, 2015, 6:02 p.m. (2015-03-02 18:02:17 UTC) #2
Wladimir Palant
Assuming that the code in prefs.js wasn't changed but merely indented, only one comment. http://codereview.adblockplus.org/5485735259930624/diff/5741031244955648/qunit/common.js ...
March 2, 2015, 7:17 p.m. (2015-03-02 19:17:17 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/5485735259930624/diff/5741031244955648/qunit/common.js File qunit/common.js (right): http://codereview.adblockplus.org/5485735259930624/diff/5741031244955648/qunit/common.js#newcode48 qunit/common.js:48: if (pref != "addListener" && pref != "removeListener") On ...
March 2, 2015, 7:28 p.m. (2015-03-02 19:28:09 UTC) #4
Wladimir Palant
March 2, 2015, 8:28 p.m. (2015-03-02 20:28:17 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld