Unified Diff: qunit/common.js
Issue 5485735259930624:
Issue 2066 - Get rid of non-standard __defineGetter__, __defineSetter__, and __lookupGetter__ (Closed)
Patch Set:
Created March 1, 2015, 1:14 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/utils.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: qunit/common.js |
| =================================================================== |
| --- a/qunit/common.js |
| +++ b/qunit/common.js |
| @@ -44,8 +44,10 @@ |
| { |
| this._pbackup = Object.create(null); |
| for (var pref in Prefs) |
| - if (Prefs.__lookupSetter__(pref)) |
| + { |
| + if (pref != "addListener" && pref != "removeListener") |
|
Wladimir Palant
2015/03/02 19:17:17
I generally try to avoid lists that have to by kep
Sebastian Noack
2015/03/02 19:28:09
IMO, checking for a dynamic getter was a footgun.
|
| this._pbackup[pref] = Prefs[pref]; |
| + } |
| Prefs.enabled = true; |
| } |
« no previous file with comments
|
« lib/utils.js ('k')
|
no next file »
|
no next file with comments »
