Issue 2440 - implement Source.get_cache_dir() to be used by custom filters/globals

[kzar, 2015-04-30 15:35:35]

LGTM

[Wladimir Palant, 2015-04-30 15:45:08]

http://codereview.adblockplus.org/5488197752586240/diff/5649050225344512/cms/...
File cms/sources.py (right):

http://codereview.adblockplus.org/5488197752586240/diff/5649050225344512/cms/...
cms/sources.py:214: self._origin = urlparse.urlsplit(repo).path.strip('/')
|hg archive| won't work for remote repositories, so repo is a local path. So
this should be something like:

self._name = os.path.basename(repo) or os.path.basename(os.path.dirname(repo))

I'm not amused any more. For the last time: if you submit code for review, it
has to be tested! If it isn't tested then at the very least you should point
that out. You can also ask me if you need help finding a way to test your code.

[Sebastian Noack, 2015-04-30 18:09:19]

http://codereview.adblockplus.org/5488197752586240/diff/5649050225344512/cms/...
File cms/sources.py (right):

http://codereview.adblockplus.org/5488197752586240/diff/5649050225344512/cms/...
cms/sources.py:214: self._origin = urlparse.urlsplit(repo).path.strip('/')
On 2015/04/30 15:45:09, Wladimir Palant wrote:
> |hg archive| won't work for remote repositories, so repo is a local path. So
> this should be something like:
> 
> self._name = os.path.basename(repo) or os.path.basename(os.path.dirname(repo))
> 
> I'm not amused any more. For the last time: if you submit code for review, it
> has to be tested! If it isn't tested then at the very least you should point
> that out. You can also ask me if you need help finding a way to test your
code.

Fixed. Note that urlparse.urlsplit() did actually work (for local file paths).
But instead the last part the full path was considered.

[Wladimir Palant, 2015-04-30 18:48:31]

LGTM