Issue 2440 - implement Source.get_cache_dir() to be used by custom filters/globals

cms/sources.py

Index: cms/sources.py
===================================================================
--- a/cms/sources.py
+++ b/cms/sources.py
@@ -211,6 +211,8 @@
     command = ["hg", "-R", repo, "id", "-n", "-r", "default"]
     self.version = subprocess.check_output(command).strip()
 
+    self._origin = urlparse.urlsplit(repo).path.strip('/')

[Wladimir Palant, 2015/04/30 15:45:09]

|hg archive| won't work for remote repositories, so repo is a local path. So
this should be something like:

self._name = os.path.basename(repo) or os.path.basename(os.path.dirname(repo))

I'm not amused any more. For the last time: if you submit code for review, it
has to be tested! If it isn't tested then at the very least you should point
that out. You can also ask me if you need help finding a way to test your code.

[Sebastian Noack, 2015/04/30 18:09:19]

Fixed. Note that urlparse.urlsplit() did actually work (for local file paths).
But instead the last part the full path was considered.

+
   def __enter__(self):
     return self
 
@@ -240,6 +242,10 @@
       if filename.startswith(prefix):
         yield filename[len(prefix):]
 
+  if os.name == "posix":
+    def get_cache_dir(self):
+      return "/var/cache/" + self._origin
+
 class FileSource(Source):
   def __init__(self, dir):
     self._dir = dir
@@ -280,3 +286,6 @@
           do_list(path, relpath + filename + "/")
     do_list(self.get_path(subdir), "")
     return result
+
+  def get_cache_dir(self):
+    return os.path.join(self._dir, "cache")