Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5499340072157184: Issue 2420 - Update notification tests (Closed)

Created:
June 8, 2015, 11:29 a.m. by Felix Dahlke
Modified:
June 15, 2015, 10:40 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2420 - Update notification tests

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Rebased, addressed comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -22 lines) Patch
M chrome/content/tests/notification.js View 1 12 chunks +47 lines, -22 lines 1 comment Download

Messages

Total messages: 4
Felix Dahlke
June 8, 2015, 11:30 a.m. (2015-06-08 11:30:56 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5499340072157184/diff/5741031244955648/chrome/content/tests/notification.js File chrome/content/tests/notification.js (right): http://codereview.adblockplus.org/5499340072157184/diff/5741031244955648/chrome/content/tests/notification.js#newcode21 chrome/content/tests/notification.js:21: Notification.markAsShown(notification.id); Shouldn't this be called in showListener above? http://codereview.adblockplus.org/5499340072157184/diff/5741031244955648/chrome/content/tests/notification.js#newcode61 ...
June 8, 2015, 11:45 a.m. (2015-06-08 11:45:21 UTC) #2
Felix Dahlke
New patch set is up. http://codereview.adblockplus.org/5499340072157184/diff/5741031244955648/chrome/content/tests/notification.js File chrome/content/tests/notification.js (right): http://codereview.adblockplus.org/5499340072157184/diff/5741031244955648/chrome/content/tests/notification.js#newcode21 chrome/content/tests/notification.js:21: Notification.markAsShown(notification.id); On 2015/06/08 11:45:21, ...
June 8, 2015, 7:36 p.m. (2015-06-08 19:36:53 UTC) #3
Wladimir Palant
June 8, 2015, 8:46 p.m. (2015-06-08 20:46:46 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld