Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5501516697829376: Issue 1161 - Anti-adblock notifications were triggered on similar domains (Closed)

Created:
July 29, 2014, 8:58 a.m. by Thomas Greiner
Modified:
July 31, 2014, 8:18 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1161 - Anti-adblock notifications were triggered on similar domains

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M lib/antiadblockInit.js View 1 2 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7
Thomas Greiner
July 29, 2014, 8:59 a.m. (2014-07-29 08:59:46 UTC) #1
Wladimir Palant
LGTM However, seeing how this has been implemented in notification.js - a Matcher() instance is ...
July 29, 2014, 9:37 a.m. (2014-07-29 09:37:38 UTC) #2
Wladimir Palant
Sorry, not LGTM above - I forgot that there is still an issue in your ...
July 29, 2014, 9:38 a.m. (2014-07-29 09:38:25 UTC) #3
Thomas Greiner
Done. Regarding the Matcher instances you can find the discussion from that time at http://codereview.adblockplus.org/5538776168267776/diff/5629499534213120/lib/notification.js#newcode189 ...
July 29, 2014, 10:15 a.m. (2014-07-29 10:15:53 UTC) #4
Wladimir Palant
LGTM I guess it is better to create a new issue on the matcher caching. ...
July 29, 2014, 12:18 p.m. (2014-07-29 12:18:20 UTC) #5
Thomas Greiner
I missed that the domain variable was also used in one of the checks.
July 29, 2014, 3:56 p.m. (2014-07-29 15:56:09 UTC) #6
Wladimir Palant
July 30, 2014, 2:04 p.m. (2014-07-30 14:04:02 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld