Issue 5506777797885952: Issue 1530 - Improve detecting of subrequest issued by flash addon

Issue 5506777797885952: Issue 1530 - Improve detecting of subrequest issued by flash addon (Closed)

Created:
Nov. 12, 2014, 8:13 a.m. by sergei

Modified:
Nov. 19, 2014, 11:41 a.m.

Reviewers:
Oleksandr

CC:
Felix Dahlke, Eric

Visibility:
Public.

Description

In addition No issue - Improve detecting of XmlHttmlRequest requests by checking whether there is "X-Requested-With" header with the value "XMLHttpRequest". - make g_blockedByABPPage const - ExtractHttpHeader returns pair<value: string, isFound: bool> - validate szURL and szHeaders arguments in WBPassthruSink::BeginningTransaction - check that pszAdditionalHeaders is not nullptr before dereferencing # There are also some non-relevant changes, feel free to let me know if something should be in another commit.

Patch Set 1 #

Total comments: 7

Patch Set 2 : remove changes for another issue #

Created: Nov. 13, 2014, 8:43 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	src/plugin/PluginWbPassThrough.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/plugin/PluginWbPassThrough.cpp	View	1	3 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Oleksandr

Please combine unrelated changes into a separate commit. That way it'll be easier to pinpoint ...

Nov. 13, 2014, 4:44 a.m. (2014-11-13 04:44:42 UTC) #2

sergei

http://codereview.adblockplus.org/5506777797885952/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp File src/plugin/PluginWbPassThrough.cpp (right): http://codereview.adblockplus.org/5506777797885952/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp#newcode16 src/plugin/PluginWbPassThrough.cpp:16: const std::string g_blockedByABPPage = "<!DOCTYPE html>" On 2014/11/13 04:44:42, ...

Nov. 13, 2014, 8:49 a.m. (2014-11-13 08:49:31 UTC) #3

LGTM!

Expand All Messages | Collapse All Messages