Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/team.tmpl

Issue 5507124440334336: Made the team size calculated dynamically, based on the list of team members, which is defined only… (Closed)
Patch Set: Adressed comments Created Dec. 11, 2013, 7:21 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « includes/size-of-team-plus-one.tmpl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 title=Meet the Team 1 title=Meet the Team
2 2
3 <header class="page-title"> 3 <header class="page-title">
4 <h1>Meet the Team</h1> 4 <h1>Meet the Team</h1>
5 </header> 5 </header>
6 6
7 {%- set people = [ 7 {%- from "globals" import people %}
8 ("2011-08-22", "palant.png", "Wladimir Palant", "Founder & CTO", "Computer sci entist and the original developer of Adblock Plus"),
9 ("2011-08-22", "faida.png", "Till Faida", "Founder & CEO", "Entrepreneur with a professional background in online marketing"),
10 ("2011-09-20", "schumacher.jpeg", "Tim Schumacher", "Investor & Advisor", "Ser ial entrepreneur with a passion for challenging Internet projects"),
11 ("2012-09-01", "dahlke.png", "Felix Dahlke", "Lead Developer", "Description go es here. Let me know your short bio."),
12 ("2012-11-01", "dommers.png", "Christian Dommers", "Head of Business Developme nt", "Business developer, entrepreneur and project manager with a background in Internet publishing"),
13 ("2012-08-01", "kawa.jpeg", "Arthur Kawa", "IT Officer Trainee", "Longtime Adb lock Plus contributor, loves music, concerts and bacon"),
14 ("2012-09-01", "plas.png", "Job Plas", "Project Manager", "Passionate about ev erything tech. Loves The Office, Gangnam Style and schnitzel. MSc & BBA in inter national business."),
15 ("2012-12-01", "hughes.png", "Eric Hughes", "Developer", "Description goes her e. Let me know your short bio."),
16 ("2013-06-01", "hartz.png", "Sven Hartz", "User Experience Designer", "Compute r scientist and creative head with a passion for making things clean and simple" ),
17 ("2013-07-01", "noack.png", "Sebastian Noack", "Developer", "Open source devel oper since 2004, into volleyball, board games and crocheting"),
18 ("2013-01-01", "wilms.png", "Nadja Wilms", "Office Assistant", "Description go es here. Let me know your short bio."),
19 ("2013-07-01", "ben.jpeg", "Ben Williams", "PR Manager", "Lion-tamer, ex-footb all star, used to date a model with only one name."),
20 ("2013-07-01", "lai.jpeg", "Xiaojun Lai", "Country Manager China", "MS in inte rnational business, loves traveling and cooking."),
21 ("2012-07-01", "greiner.jpeg", "Thomas Greiner", "Developer", "Web enthusiast and developer with strong beliefs on openness, transparency and accessibility"),
22 ("2012-12-01", "paraska.jpeg", "Oleksandr Paraska", "Developer", "Longtime Adb lock Plus for IE developer (yes, seriously). Loves making crêpes."),
23 ("2013-07-01", "caballero.jpeg", "Manuel Caballero", "Junior Project Manager", "PhD candidate in art history, country manager for Spain & LatAm, Germanophile and metal head"),
24 ("2013-07-01", "vervoorts.png", "Christian Vervoorts", "IT Admin", "Linux expe rt who keeps our server and networks running smoothly"),
25 ("2013-11-01", "carrales.png", "Adrian Carrales", "Intern", "International bus iness student, with a passion for marketing, sports and music"),
26 ("2013-03-01", "yu.jpeg", "Vicky Yu", "Intern", "IT outsider, enjoy researchin g, occasional wanderlust"),
27 ] %}
28 8
29 {%- macro profile(date, image, name, title, description) %} 9 {%- macro profile(date, image, name, title, description) %}
30 <div class="profile column"> 10 <div class="profile column">
31 <p> 11 <p>
32 <img class="profile-image" src="/images/people/{{image}}" width="120" heig ht="120" alt=""/> 12 <img class="profile-image" src="/images/people/{{image}}" width="120" heig ht="120" alt=""/>
33 </p> 13 </p>
34 <h3 class="heading centered"><span>{{title}}</span></h3> 14 <h3 class="heading centered"><span>{{title}}</span></h3>
35 <h1>{{name}}</h1> 15 <h1>{{name}}</h1>
36 <h2>{{description}}</h2> 16 <h2>{{description}}</h2>
37 </div> 17 </div>
38 {% endmacro %} 18 {% endmacro %}
39 19
40 <div class="content-block columns-container four-columns"> 20 <div class="content-block columns-container four-columns">
41 {%- for person in people|datesort(basedate="2011-02-22") %} 21 {%- for person in people|datesort(basedate="2011-02-22") %}
42 {%- if loop.index % 4 == 1 and not loop.first %} 22 {%- if loop.index % 4 == 1 and not loop.first %}
43 </div> 23 </div>
44 <div class="content-block columns-container four-columns"> 24 <div class="content-block columns-container four-columns">
45 {%- endif %} 25 {%- endif %}
46 26
47 {{profile(*person)}} 27 {{profile(*person)}}
48 {%- endfor %} 28 {%- endfor %}
49 </div> 29 </div>
OLDNEW
« no previous file with comments | « includes/size-of-team-plus-one.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld