Made the team size calculated dynamically, based on the list of team members, which is defined only…

Made the team size calculated dynamically, based on the list of team members, which is defined only…

[Wladimir Palant, 2013-12-11 18:48:28]

http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/incl...
File includes/jobs/overview.md (right):

http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/incl...
includes/jobs/overview.md:3: <p>We are <? include size-of-team ?> people who
manage the business and development ends of an open source product that’s been
downloaded over 250 million times. And we’re looking to change a billion-dollar
industry. Like them odds? Then maybe we should change that number to 20 …</p>
We need to replace the number 20 as well - probably by a template
size-of-team-plus-one :)

Why did you add <p> tags, doesn't Markdown generate them automatically any more?

[Sebastian Noack, 2013-12-11 19:30:27]

http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/incl...
File includes/jobs/overview.md (right):

http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/incl...
includes/jobs/overview.md:3: <p>We are <? include size-of-team ?> people who
manage the business and development ends of an open source product that’s been
downloaded over 250 million times. And we’re looking to change a billion-dollar
industry. Like them odds? Then maybe we should change that number to 20 …</p>
On 2013/12/11 18:48:28, Wladimir Palant wrote:
> We need to replace the number 20 as well - probably by a template
> size-of-team-plus-one :)
Done.

> Why did you add <p> tags, doesn't Markdown generate them automatically any
more?
That is because of you had decided to use angle brackets for the include syntax.
;) Angle brackets are escape by markdown if they occur within a paragraph.
However wrapping the paragraph with a <p> tag, will disable markdown for that
paragraph.

This is less than optimal. What do you think about replacing the angle brackets
in the include syntax with characters that are ignored by markdown, or at least
can be escaped?

[Wladimir Palant, 2013-12-12 07:29:28]

Mostly fine, the paths for {% include %} will have to be adjusted however once
the CMS is adjusted according to review (the file should no longer be moved on
the other hand). I also think that we should add post-processing of
&lt;?[^<>]+?&gt; to the converter instead of the <p> tags here which disable
*all* Markdown processing (like emphasis).

http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/incl...
File includes/jobs/overview.md (right):

http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/incl...
includes/jobs/overview.md:3: <p>We are <? include size-of-team ?> people who
manage the business and development ends of an open source product that’s been
downloaded over 250 million times. And we’re looking to change a billion-dollar
industry. Like them odds? Then maybe we should change that number to 20 …</p>
On 2013/12/11 19:30:28, sebastian wrote:
> What do you think about replacing the angle brackets
> in the include syntax with characters that are ignored by markdown, or at
least
> can be escaped?

This is actually intentional - Markdown recognizes processing instructions and
won't wrap them in a paragraph if they are there on their own. The escaping
inside a paragraph seems to be a bug on the other hand, the reference
implementation under http://daringfireball.net/projects/markdown/dingus doesn't
do that. As a short-term solution, we can undo the escaping in our converter. We
can also file a bug against Markdown to get the issue fixed.

[Sebastian Noack, 2013-12-12 10:37:21]

http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/incl...
File includes/jobs/overview.md (right):

http://codereview.adblockplus.org/5507124440334336/diff/5629499534213120/incl...
includes/jobs/overview.md:3: <p>We are <? include size-of-team ?> people who
manage the business and development ends of an open source product that’s been
downloaded over 250 million times. And we’re looking to change a billion-dollar
industry. Like them odds? Then maybe we should change that number to 20 …</p>
On 2013/12/12 07:29:28, Wladimir Palant wrote:
> On 2013/12/11 19:30:28, sebastian wrote:
> > What do you think about replacing the angle brackets
> > in the include syntax with characters that are ignored by markdown, or at
> least
> > can be escaped?
> 
> This is actually intentional - Markdown recognizes processing instructions and
> won't wrap them in a paragraph if they are there on their own. The escaping
> inside a paragraph seems to be a bug on the other hand, the reference
> implementation under http://daringfireball.net/projects/markdown/dingus
doesn't
> do that. As a short-term solution, we can undo the escaping in our converter.
We
> can also file a bug against Markdown to get the issue fixed.

I'm not sure whether it is a bug. You need some magic to figure out what's a tag
and what not within paragraphs, and in some cases it isn't even possible. Take
following example: "To commit with mercurial: hg commit -m <message>".
"<message>" looks like a tag, but it is just part of the text.

However handling &gt; and &lt; when post-processing includes, sounds reasonable.
I've addressed that in the other review.

[Wladimir Palant, 2013-12-13 20:58:40]

LGTM