includes/jobs/overview.md - Issue 5507124440334336: Made the team size calculated dynamically, based on the list of team members, which is defined only…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: includes/jobs/overview.md

Issue 5507124440334336: Made the team size calculated dynamically, based on the list of team members, which is defined only… (Closed)

Left Patch Set: Created Dec. 11, 2013, 6:31 p.m.

Right Patch Set: Addressed comments Created Dec. 12, 2013, 10:25 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # Join us in changing the Internet!#	1 # Join us in changing the Internet!#

2	2

3 <p>We are <? include size-of-team ?> people who manage the business and developm ent ends of an open source product that’s been downloaded over 250 million times . And we’re looking to change a billion-dollar industry. Like them odds? Then ma ybe we should change that number to 20 …</p>	3 We are <? include size-of-team ?> people who manage the business and development ends of an open source product that’s been downloaded over 250 million times. A nd we’re looking to change a billion-dollar industry. Like them odds? Then maybe we should change that number to <? include size-of-team-plus-one ?> …
Wladimir Palant 2013/12/11 18:48:28 We need to replace the number 20 as well - probabl We need to replace the number 20 as well - probably by a template size-of-team-plus-one :) Why did you add <p> tags, doesn't Markdown generate them automatically any more? Wladimir Palant 2013/12/12 07:29:28 This is actually intentional - Markdown recognizes Show quoted text On 2013/12/11 19:30:28, sebastian wrote: > What do you think about replacing the angle brackets > in the include syntax with characters that are ignored by markdown, or at least > can be escaped? This is actually intentional - Markdown recognizes processing instructions and won't wrap them in a paragraph if they are there on their own. The escaping inside a paragraph seems to be a bug on the other hand, the reference implementation under http://daringfireball.net/projects/markdown/dingus doesn't do that. As a short-term solution, we can undo the escaping in our converter. We can also file a bug against Markdown to get the issue fixed. Sebastian Noack 2013/12/12 10:37:21 I'm not sure whether it is a bug. You need some ma Show quoted text On 2013/12/12 07:29:28, Wladimir Palant wrote: > On 2013/12/11 19:30:28, sebastian wrote: > > What do you think about replacing the angle brackets > > in the include syntax with characters that are ignored by markdown, or at > least > > can be escaped? > > This is actually intentional - Markdown recognizes processing instructions and > won't wrap them in a paragraph if they are there on their own. The escaping > inside a paragraph seems to be a bug on the other hand, the reference > implementation under http://daringfireball.net/projects/markdown/dingus doesn't > do that. As a short-term solution, we can undo the escaping in our converter. We > can also file a bug against Markdown to get the issue fixed. I'm not sure whether it is a bug. You need some magic to figure out what's a tag and what not within paragraphs, and in some cases it isn't even possible. Take following example: "To commit with mercurial: hg commit -m <message>". "<message>" looks like a tag, but it is just part of the text. However handling > and < when post-processing includes, sounds reasonable. I've addressed that in the other review.
LEFT	RIGHT