Issue #1204 - Remove A/B testing for donation button in firstrun page in IE

html/static/js/firstRun.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 56 matching lines @@
     }
 
     iframe.removeEventListener("load", popupLoadListener);
   };
   iframe.addEventListener("load", popupLoadListener);
 
   iframe.src = url;
   glassPane.className = "visible";
 }
 
-function initSocialLinks(variant)
+function initSocialLinks()
 {
   // Share popup doesn't work in <IE9 so don't show it
   if (/MSIE [6-8]/.test(navigator.appVersion))
     return;
 
   var networks = ["twitter", "facebook", "gplus"];
   networks.forEach(function(network)
   {
-    var link = document.getElementById("share-" + network + "-" + variant);
+    var link = document.getElementById("share-" + network);
     link.addEventListener("click", function(e)
     {
       e.preventDefault();
-      openSharePopup(getDocLink("share-" + network) + "&variant=" + variant);
+      openSharePopup(getDocLink("share-" + network));
     });
   });
 }
 
 function getDocLink(page)
 {
   return Prefs.documentation_link
               .replace(/%LINK%/g, page)
               .replace(/%LANG%/g, Utils.appLocale);
 }
 
 function initTranslations()
 {
   // Map message ID to HTML element ID
   var mapping = {
     "aa-title": "first-run-aa-title",
     "aa-text": "first-run-aa-text",
     "title-main": AdblockPlus.isUpdate() ? "first-run-title-update" : "first-run-title-install",
-    "share-text1": "first-run-share1",
-    "share-text2": "first-run-share2",
     "share-donate": "first-run-share2-donate",
-    "share2-connection": "first-run-share2-or"
+    "share-text": "first-run-share2",
+    "share-connection": "first-run-share2-or",

[Thomas Greiner, 2014/11/03 17:14:12]

Did you check whether IE8 can deal with trailing commas in object literals?

[Oleksandr, 2014/11/04 11:18:24]

It worked fine in IE8. Removed it anyway.

[Thomas Greiner, 2014/11/04 11:27:46]

Great, thanks.

   };
 
   document.title = AdblockPlus.getMessage("first-run", mapping['title-main']);
   for (var i in mapping)
   {
     var element = document.getElementById(i);
     setElementText(element, AdblockPlus.getMessage("first-run", mapping[i]));
   }
 }
 
 function init()
 {
-  // Choose a share text variant randomly
-  var variant = Math.floor(Math.random() * 2) + 1;
-  var classList = document.documentElement.className.split(" ");
-  classList.push("share-variant-" + variant);
-  document.documentElement.className = classList.join(" ");
-
   initTranslations();
-  initSocialLinks(variant);
+  initSocialLinks();
   setLinks("aa-text", getDocLink("acceptable_ads_criteria"), "index.html");
 
   var donateLink = document.getElementById("share-donate");
-  donateLink.href = getDocLink("donate") + "&variant=" + variant;
+  donateLink.href = getDocLink("donate");
 }
 
 // Inserts i18n strings into matching elements. Any inner HTML already in the 
 // element is parsed as JSON and used as parameters to substitute into 
 // placeholders in the i18n message.
 setElementText = function(element, elementHtml)
 {
   function processString(str, element)
   {
     var match = /^(.*?)<(a|strong)>(.*?)<\/\2>(.*)$/.exec(str);
@@ skipping 35 matching lines @@
       links[i].href = curArg;
       links[i].setAttribute("target", "_blank");
     }
     else if (typeof curArg == "function")
     {
       links[i].href = "javascript:void(0);";
       links[i].addEventListener("click", curArg, false);
     }
   }
 }