Issue #1204 - Remove A/B testing for donation button in firstrun page in IE

Issue #1204 - Remove A/B testing for donation button in firstrun page in IE

[sergei, 2014-10-27 23:24:22]

LGTM

Interesting that IE shows me a dialog "Internet Explorer restricted this webpage
from running scripts or ActiveX controls." and the page is correctly displayed
only after I click "Allow blocked content".

[Oleksandr, 2014-11-01 09:14:35]

Adding Thomas as a reviewer

[Thomas Greiner, 2014-11-03 17:14:11]

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
File html/static/css/firstRun.css (right):

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/static/css/firstRun.css:64: #share,
Nit: Remove the trailing comma.

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/static/css/firstRun.css:71: html.share #share,
This block was only used to show the correct variant but since this is no longer
necessary you can just remove the "display: block" from here and "display: none"
from above.

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/static/css/firstRun.css:71: html.share #share,
Nit: Remove the trailing comma.

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/static/css/firstRun.css:109: margin: 35px 0px;
Why are these changes necessary?

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/static/css/firstRun.css:116: margin: 35px 20px;
Same as above: Why are these changes necessary?

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
File html/static/js/firstRun.js (right):

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/static/js/firstRun.js:111: "share-connection": "first-run-share2-or",
Did you check whether IE8 can deal with trailing commas in object literals?

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
File html/templates/firstRun.html (right):

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/templates/firstRun.html:57: <a id="share-gplus" class="share-image
share-gplus" href="https://www.google.com/+AdblockPlus" target="_blank"></a>
We don't need the "share-<network>" classes anymore. Instead we can use the
element ID.

[Oleksandr, 2014-11-04 11:18:24]

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
File html/static/css/firstRun.css (right):

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/static/css/firstRun.css:109: margin: 35px 0px;
On 2014/11/03 17:14:12, Thomas Greiner wrote:
> Why are these changes necessary?

This was needed to align the donate button vertically. That is no longer needed
with current changes.

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
File html/static/js/firstRun.js (right):

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/static/js/firstRun.js:111: "share-connection": "first-run-share2-or",
On 2014/11/03 17:14:12, Thomas Greiner wrote:
> Did you check whether IE8 can deal with trailing commas in object literals?

It worked fine in IE8. Removed it anyway.

[Thomas Greiner, 2014-11-04 11:27:46]

LGTM

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
File html/static/js/firstRun.js (right):

http://codereview.adblockplus.org/5545110112567296/diff/5629499534213120/html...
html/static/js/firstRun.js:111: "share-connection": "first-run-share2-or",
On 2014/11/04 11:18:24, Oleksandr wrote:
> On 2014/11/03 17:14:12, Thomas Greiner wrote:
> > Did you check whether IE8 can deal with trailing commas in object literals?
> 
> It worked fine in IE8. Removed it anyway.

Great, thanks.