Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: html/static/js/firstRun.js

Issue 5545110112567296: Issue #1204 - Remove A/B testing for donation button in firstrun page in IE (Closed)
Left Patch Set: Created Oct. 27, 2014, 1:16 a.m.
Right Patch Set: Cleanup. Addressing comments. Created Nov. 4, 2014, 11:10 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « html/static/css/firstRun.css ('k') | html/templates/firstRun.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 function initTranslations() 102 function initTranslations()
103 { 103 {
104 // Map message ID to HTML element ID 104 // Map message ID to HTML element ID
105 var mapping = { 105 var mapping = {
106 "aa-title": "first-run-aa-title", 106 "aa-title": "first-run-aa-title",
107 "aa-text": "first-run-aa-text", 107 "aa-text": "first-run-aa-text",
108 "title-main": AdblockPlus.isUpdate() ? "first-run-title-update" : "first-run -title-install", 108 "title-main": AdblockPlus.isUpdate() ? "first-run-title-update" : "first-run -title-install",
109 "share-donate": "first-run-share2-donate", 109 "share-donate": "first-run-share2-donate",
110 "share-text": "first-run-share2", 110 "share-text": "first-run-share2",
111 "share-connection": "first-run-share2-or", 111 "share-connection": "first-run-share2-or"
Thomas Greiner 2014/11/03 17:14:12 Did you check whether IE8 can deal with trailing c
Oleksandr 2014/11/04 11:18:24 It worked fine in IE8. Removed it anyway.
Thomas Greiner 2014/11/04 11:27:46 Great, thanks.
112 }; 112 };
113 113
114 document.title = AdblockPlus.getMessage("first-run", mapping['title-main']); 114 document.title = AdblockPlus.getMessage("first-run", mapping['title-main']);
115 for (var i in mapping) 115 for (var i in mapping)
116 { 116 {
117 var element = document.getElementById(i); 117 var element = document.getElementById(i);
118 setElementText(element, AdblockPlus.getMessage("first-run", mapping[i])); 118 setElementText(element, AdblockPlus.getMessage("first-run", mapping[i]));
119 } 119 }
120 } 120 }
121 121
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 links[i].href = curArg; 175 links[i].href = curArg;
176 links[i].setAttribute("target", "_blank"); 176 links[i].setAttribute("target", "_blank");
177 } 177 }
178 else if (typeof curArg == "function") 178 else if (typeof curArg == "function")
179 { 179 {
180 links[i].href = "javascript:void(0);"; 180 links[i].href = "javascript:void(0);";
181 links[i].addEventListener("click", curArg, false); 181 links[i].addEventListener("click", curArg, false);
182 } 182 }
183 } 183 }
184 } 184 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld