Issue 293 - AdBlock button is slow to appear on toolbar after launching Firefox

Issue 293 - AdBlock button is slow to appear on toolbar after launching Firefox

[Wladimir Palant, 2014-05-23 11:50:50]

http://codereview.adblockplus.org/5634514093080576/diff/5629499534213120/lib/...
File lib/ui.js (right):

http://codereview.adblockplus.org/5634514093080576/diff/5629499534213120/lib/...
lib/ui.js:1290: return;
I guess I could just as well remove that failsafe - any functions that can be
triggered here can also be triggered via the menu. And none of them seem
problematic even if filters aren't loaded, see my comment in the issue.

[Wladimir Palant, 2014-05-23 12:45:26]

I fixed first-run page, with the previous patch it was opening on every update -
the first-run actions were running from applyToWindow() which was typically
before the filters loaded. Also removed the unnecessary failsafe as indicated by
my previous comment.

[Thomas Greiner, 2014-05-23 16:10:30]

http://codereview.adblockplus.org/5634514093080576/diff/5629499534213120/lib/...
File lib/ui.js (right):

http://codereview.adblockplus.org/5634514093080576/diff/5629499534213120/lib/...
lib/ui.js:1290: return;
On 2014/05/23 11:50:50, Wladimir Palant wrote:
> I guess I could just as well remove that failsafe - any functions that can be
> triggered here can also be triggered via the menu. And none of them seem
> problematic even if filters aren't loaded, see my comment in the issue.

Doesn't seem to affect the upcoming changes to the icon popup so that's fine
with me.

http://codereview.adblockplus.org/5634514093080576/diff/6231550869897216/lib/...
File lib/ui.js (right):

http://codereview.adblockplus.org/5634514093080576/diff/6231550869897216/lib/...
lib/ui.js:502: firstRunActions: function(window)
Is there a case in which firstRunActions are / could be run without
this.firstRunDone being true? If not, why not include it in this function
directly instead of right before calling firstRunActions?

[Wladimir Palant, 2014-05-26 11:16:52]

http://codereview.adblockplus.org/5634514093080576/diff/6231550869897216/lib/...
File lib/ui.js (right):

http://codereview.adblockplus.org/5634514093080576/diff/6231550869897216/lib/...
lib/ui.js:502: firstRunActions: function(window)
This was pretty much premature optimization on my end, moved the check inside
the function.

[Thomas Greiner, 2014-05-26 13:28:03]

LGTM