Issue 2134 - Support both .raw and .html file extensions for raw HTML

Issue 2134 - Support both .raw and .html file extensions for raw HTML

[Sebastian Noack, 2015-03-12 20:05:10]

Frankly, I wonder whether we should just remove the raw format. Couldn't all it
does be implemented with jinja2?

http://codereview.adblockplus.org/5634661371871232/diff/5629499534213120/cms/...
File cms/converters.py (left):

http://codereview.adblockplus.org/5634661371871232/diff/5629499534213120/cms/...
cms/converters.py:338: "raw": RawConverter,
Should you remove the old extension?

[Wladimir Palant, 2015-03-12 20:46:28]

On 2015/03/12 20:05:10, Sebastian Noack wrote:
> Frankly, I wonder whether we should just remove the raw format. Couldn't all
it
> does be implemented with jinja2?

Sure, and the goal is certainly replacing all the raw HTML files by Markdown. In
the meantime we'll have people editing these files however - and the raw HTML
format is still simpler and easier to read than Jinja2 templates.

http://codereview.adblockplus.org/5634661371871232/diff/5629499534213120/cms/...
File cms/converters.py (left):

http://codereview.adblockplus.org/5634661371871232/diff/5629499534213120/cms/...
cms/converters.py:338: "raw": RawConverter,
On 2015/03/12 20:05:10, Sebastian Noack wrote:
> Should you remove the old extension?

As I said in the issue description - we have repositories using the .raw
extension right now. Once these have been updated we should remove the old
extension of course.

[Sebastian Noack, 2015-03-12 20:47:09]

LGTM

[Sebastian Noack, 2015-03-12 20:48:09]

http://codereview.adblockplus.org/5634661371871232/diff/5629499534213120/cms/...
File cms/converters.py (left):

http://codereview.adblockplus.org/5634661371871232/diff/5629499534213120/cms/...
cms/converters.py:338: "raw": RawConverter,
On 2015/03/12 20:46:28, Wladimir Palant wrote:
> On 2015/03/12 20:05:10, Sebastian Noack wrote:
> > Should you remove the old extension?
> 
> As I said in the issue description - we have repositories using the .raw
> extension right now. Once these have been updated we should remove the old
> extension of course.

Sorry, too late, but please add a comment above that .raw is deprecated at
least.

[Wladimir Palant, 2015-03-12 20:59:11]

Note, rebasing changes in the new patchset.

http://codereview.adblockplus.org/5634661371871232/diff/5629499534213120/cms/...
File cms/converters.py (left):

http://codereview.adblockplus.org/5634661371871232/diff/5629499534213120/cms/...
cms/converters.py:338: "raw": RawConverter,
On 2015/03/12 20:48:09, Sebastian Noack wrote:
> On 2015/03/12 20:46:28, Wladimir Palant wrote:
> > On 2015/03/12 20:05:10, Sebastian Noack wrote:
> > > Should you remove the old extension?
> > 
> > As I said in the issue description - we have repositories using the .raw
> > extension right now. Once these have been updated we should remove the old
> > extension of course.
> 
> Sorry, too late, but please add a comment above that .raw is deprecated at
> least.

Done.

[Sebastian Noack, 2015-03-12 21:09:25]

LGTM