Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5653767139622912: Issue 213 - Make sure kick.py can still parse Puppet files with newer Puppet releases (Closed)

Created:
March 26, 2014, 8:47 a.m. by Wladimir Palant
Modified:
March 26, 2014, 12:19 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 213 - Make sure kick.py can still parse Puppet files with newer Puppet releases

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M kick.py View 1 chunk +3 lines, -2 lines 2 comments Download

Messages

Total messages: 4
Wladimir Palant
March 26, 2014, 8:47 a.m. (2014-03-26 08:47:44 UTC) #1
Felix Dahlke
Tested with Puppet 2.7.6, works fine. One question though. http://codereview.adblockplus.org/5653767139622912/diff/5629499534213120/kick.py File kick.py (right): http://codereview.adblockplus.org/5653767139622912/diff/5629499534213120/kick.py#newcode68 kick.py:68: ...
March 26, 2014, 11:19 a.m. (2014-03-26 11:19:55 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5653767139622912/diff/5629499534213120/kick.py File kick.py (right): http://codereview.adblockplus.org/5653767139622912/diff/5629499534213120/kick.py#newcode68 kick.py:68: stdout=subprocess.PIPE).communicate(parseScript) On 2014/03/26 11:19:55, Felix H. Dahlke wrote: > ...
March 26, 2014, 11:27 a.m. (2014-03-26 11:27:41 UTC) #3
Felix Dahlke
March 26, 2014, 11:37 a.m. (2014-03-26 11:37:59 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld