Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1232)

Issue 5654617534758912: Issue 2237 - Added unit tests for notification opt-out (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Thomas Greiner
Modified:
4 years, 1 month ago
Visibility:
Public.

Description

Issue 2237 - Added unit tests for notification opt-out

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added extra tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M chrome/content/tests/notification.js View 1 2 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
4 years, 3 months ago (2015-04-13 16:12:23 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/5654617534758912/diff/5629499534213120/chrome/content/tests/notification.js File chrome/content/tests/notification.js (right): http://codereview.adblockplus.org/5654617534758912/diff/5629499534213120/chrome/content/tests/notification.js#newcode406 chrome/content/tests/notification.js:406: deepEqual(Notification.getNextToShow(), critical, "Critical notifications are not ignored"); This test ...
4 years, 1 month ago (2015-05-26 11:23:19 UTC) #2
Thomas Greiner
http://codereview.adblockplus.org/5654617534758912/diff/5629499534213120/chrome/content/tests/notification.js File chrome/content/tests/notification.js (right): http://codereview.adblockplus.org/5654617534758912/diff/5629499534213120/chrome/content/tests/notification.js#newcode406 chrome/content/tests/notification.js:406: deepEqual(Notification.getNextToShow(), critical, "Critical notifications are not ignored"); On 2015/05/26 ...
4 years, 1 month ago (2015-05-28 13:24:18 UTC) #3
Wladimir Palant
4 years, 1 month ago (2015-05-28 14:06:06 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5