Issue 260 - [Typed objects] Implement type inheritance

Issue 260 - [Typed objects] Implement type inheritance

[Wladimir Palant, 2014-04-22 19:21:30]

Forgot to add Felix and Tom to CC, done that now.

[Wladimir Palant, 2014-04-28 07:03:37]

http://codereview.adblockplus.org/5656302898380800/diff/5629499534213120/lib/...
File lib/typedObjects/objectTypes.js (right):

http://codereview.adblockplus.org/5656302898380800/diff/5629499534213120/lib/...
lib/typedObjects/objectTypes.js:219: }
The logic here was wrong: if no constructor is defined for the class then the
superclass constructor should still be called.

[René Jeschke, 2014-05-02 16:16:37]

Just the 'isInstance' issue, rest: LGTM

http://codereview.adblockplus.org/5656302898380800/diff/5724160613416960/lib/...
File lib/typedObjects/objectTypes.js (right):

http://codereview.adblockplus.org/5656302898380800/diff/5724160613416960/lib/...
lib/typedObjects/objectTypes.js:246: isinstance:
fixedPropertyDescriptor(isinstance.bind(null, typeId)),
Just wondering, every other member name you use is camel-case, but not this one.

Shouldn't this then be called 'isInstance'?

[Wladimir Palant, 2014-05-02 19:14:30]

http://codereview.adblockplus.org/5656302898380800/diff/5724160613416960/lib/...
File lib/typedObjects/objectTypes.js (right):

http://codereview.adblockplus.org/5656302898380800/diff/5724160613416960/lib/...
lib/typedObjects/objectTypes.js:246: isinstance:
fixedPropertyDescriptor(isinstance.bind(null, typeId)),
On 2014/05/02 16:16:37, René Jeschke wrote:
> Just wondering, every other member name you use is camel-case, but not this
one.
> 
> Shouldn't this then be called 'isInstance'?

It's really because the JavaScript operator is called "isinstance" - but you are
right, it should be camel-cased.

[René Jeschke, 2014-05-12 09:26:19]

LGTM