Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5663591407550464: Removed unused ext.browserAction.setTitle function (Closed)

Created:
Jan. 23, 2014, 4:30 p.m. by Thomas Greiner
Modified:
Jan. 24, 2014, 9:36 a.m.
Reviewers:
snoack, Wladimir Palant
Visibility:
Public.

Description

The only code that called ext.browserAction.setTitle has been removed so we can get rid of that function: https://hg.adblockplus.org/adblockpluschrome/diff/b14de2a3ae14/background.js

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/ext/background.js View 1 chunk +0 lines, -4 lines 0 comments Download
M safari/ext/background.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3
Thomas Greiner
Jan. 23, 2014, 4:34 p.m. (2014-01-23 16:34:12 UTC) #1
Wladimir Palant
LGTM even though I suspect Sebastian will have something against that change.
Jan. 23, 2014, 6:36 p.m. (2014-01-23 18:36:06 UTC) #2
Thomas Greiner
Jan. 24, 2014, 9:33 a.m. (2014-01-24 09:33:45 UTC) #3
On 2014/01/23 18:36:06, Wladimir Palant wrote:
> LGTM even though I suspect Sebastian will have something against that change.

I made that sure beforehand:
2014-01-23 17:28 <snoack> greiner: I don't mind whether browserAction.setTitle
stays in their.

Powered by Google App Engine
This is Rietveld