make abp-128.png icon non web accessible

background.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 333 matching lines @@
   }
   else if (activeNotification.links && activeNotification.links[index])
   {
     ext.windows.getLastFocused(function(win)
     {
       win.openTab(Utils.getDocLink(activeNotification.links[index]));
     });
   }
 }
 
+function imgToBase64(url, callback)
+{
+  var canvas = document.createElement("CANVAS"),

[Wladimir Palant, 2014/03/28 14:18:29]

Nit: document.createElement("canvas") please (lowercase tag names are compatible
to both HTML and XHTML).

[saroyanm, 2014/03/28 15:16:02]

Done.

+  ctx = canvas.getContext("2d"),
+  img = new Image;
+  img.src = url;
+  img.onload = function()
+  {
+    canvas.height = img.height;
+    canvas.width = img.width;
+    ctx.drawImage(img, 0, 0);
+    callback(canvas.toDataURL("image/png"));
+    canvas = null;
+  };
+}
+
 function showNotification(notification)
 {
   if (activeNotification && activeNotification.id === notification.id)
     return;
   
   activeNotification = notification;
   if (activeNotification.type === "critical" || activeNotification.type === "question")
   {
     var hasWebkitNotifications = typeof webkitNotifications !== "undefined";
     if (hasWebkitNotifications && "createHTMLNotification" in webkitNotifications)
@@ skipping 11 matching lines @@
     var hasLinks = activeNotification.links && activeNotification.links.length > 0;
     
     // Chrome on Linux does not fully support chrome.notifications yet
     // https://code.google.com/p/chromium/issues/detail?id=291485
     if (require("info").platform == "chromium" && "notifications" in chrome && navigator.platform.indexOf("Linux") == -1)
     {
       var opts = {
         type: "basic",
         title: title,
         message: message,
-        iconUrl: iconUrl,
         buttons: [],
         priority: 2 // We use the highest priority to prevent the notification from closing automatically
       };
       if (activeNotification.type === "question")
       {
         opts.buttons.push({title: ext.i18n.getMessage("overlay_notification_button_yes")});
         opts.buttons.push({title: ext.i18n.getMessage("overlay_notification_button_no")});
       }
       else
       {
         var regex = /<a>(.*?)<\/a>/g;
         var plainMessage = texts.message || "";
         var match;
         while (match = regex.exec(plainMessage))
           opts.buttons.push({title: match[1]});
       }
       
-      chrome.notifications.create("", opts, function() {});
-      chrome.notifications.onButtonClicked.addListener(notificationButtonClick);
+      imgToBase64(iconUrl, function(iconData)
+      {
+        opts["iconUrl"] = iconData;
+        chrome.notifications.create("", opts, function() {});
+        chrome.notifications.onButtonClicked.addListener(notificationButtonClick);
+      });
     }
     else if (hasWebkitNotifications && "createNotification" in webkitNotifications && activeNotification.type !== "question")
     {
       if (hasLinks)
         message += " " + ext.i18n.getMessage("notification_without_buttons");
         
-      var notification = webkitNotifications.createNotification(iconUrl, title, message);
-      notification.show();
-      notification.addEventListener("click", openNotificationLinks, false);
+      imgToBase64(iconUrl, function(iconData)
+      {
+        var notification = webkitNotifications.createNotification(iconData, title, message);
+        notification.show();
+        notification.addEventListener("click", openNotificationLinks, false);
+      });
     }
     else
     {
       var message = title + "\n" + message;
       if (hasLinks)
         message += "\n\n" + ext.i18n.getMessage("notification_with_buttons");
         
       var approved = confirm(message);
       if (activeNotification.type === "question")
         notificationButtonClick(null, approved ? 0 : 1);
@@ skipping 104 matching lines @@
   tab.sendMessage({type: "clickhide-deactivate"});
   refreshIconAndContextMenu(tab);
 });
 
 setTimeout(function()
 {
   var notificationToShow = Notification.getNextToShow();
   if (notificationToShow)
     showNotification(notificationToShow);
 }, 3 * 60 * 1000);