DescriptionThis Review is related to current ticket:
https://issues.adblockplus.org/ticket/172
Chrome works differently under Ubuntu and Chrome.
While I'm getting current error for the icons not listed in web_accessible
resources under Ubuntu:
"Denying load of
chrome-extension://ojacpngaaogckgldgfpfjjpeaegdbgcb/icons/abp-128.png. Resources
must be listed in the web_accessible_resources manifest key in order to be
loaded by pages outside the extension."
But under windows no error message and looks no need to list in web_accessible
resources.
I'll investigate that strange behavior more, maybe it's related to desktop
notifications itself under ubuntu and windows.
Anyway in Chrome official documentation is written that Resources inside of packages
using manifest_version 2 or above are blocked by default if not whitelisted
through web_accessible param in manifest.json:
https://developer.chrome.com/extensions/manifest/web_accessible_resources#availability
Also not sure if I need to generate data: URL in buildtool(python), or we can
stick to generate it in extension.
Patch Set 1 #
Total comments: 2
MessagesTotal messages: 2
|