Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5689334309060608: Issue 1523 - Make it possible to use libadblockplus compiled by MS Visual Studio 2010 (Closed)

Created:
Nov. 5, 2014, 12:04 a.m. by sergei
Modified:
Nov. 5, 2014, 11:19 a.m.
Reviewers:
Felix Dahlke
CC:
Wladimir Palant
Visibility:
Public.

Description

std::basic_string::operator[i] has an assert in MSVS2010 which verifies the size of string, in our case the size is zero and we should not call operator[]. To use MSVS2010 one has to edit craetesolution.bat

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/DefaultWebRequestWinInet.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
sergei
Nov. 5, 2014, 12:08 a.m. (2014-11-05 00:08:00 UTC) #1
Felix Dahlke
Nov. 5, 2014, 8:48 a.m. (2014-11-05 08:48:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld