src/org/adblockplus/libadblockplus/Filter.java - Issue 5697499218051072: Usage of new API, cleanups (reduced)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/org/adblockplus/libadblockplus/Filter.java

Issue 5697499218051072: Usage of new API, cleanups (reduced) (Closed)

Patch Set: Removed newly added neetutils code Created April 25, 2014, 9:31 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/org/adblockplus/libadblockplus/Filter.java

diff --git a/src/org/adblockplus/libadblockplus/Filter.java b/src/org/adblockplus/libadblockplus/Filter.java

index 8502b666add1de692849b667aa872b75b0b3e955..88a6516ac06591fbb0b8435c1d7e7ed932872886 100644

--- a/src/org/adblockplus/libadblockplus/Filter.java

+++ b/src/org/adblockplus/libadblockplus/Filter.java

@@ -17,7 +17,7 @@

package org.adblockplus.libadblockplus;

-public class Filter extends JsValue

+public final class Filter extends JsValue

Felix Dahlke 2014/04/28 07:29:01 Are you making all classes final as well while fin

René Jeschke 2014/04/28 08:34:32 Filter and Subscription are both not intended to b

Felix Dahlke 2014/04/28 10:09:41 Ah. Thought there may be some tangiable benefits m

René Jeschke 2014/04/28 10:18:34 Done.

{

static

{