Issue 1644 - Recognize <input type=image> elements with the correct type on Safari

Issue 1644 - Recognize <input type=image> elements with the correct type on Safari

[kzar, 2014-12-03 09:58:56]

After you explained in IRC it LGTM.

Nitpick: beforeLoad event isn't well documented online so perhaps leave a
comment in code to explain what's going on. I found it non-obvious until you
explained it to me.

[Sebastian Noack, 2014-12-03 10:13:43]

The beforeload event is documented here:
https://developer.apple.com/library/safari/documentation/tools/conceptual/saf...

However, the code changed here just maps tag names to request types, which IMO
is pretty obvious.

[kzar, 2014-12-03 10:16:12]

I saw that page but I couldn't see anything to say exactly when the event was
triggered. It has a quick list of examples but nothing to say if an text input
with a background image would trigger the event or not for example.

On 2014/12/03 10:13:43, Sebastian Noack wrote:
> The beforeload event is documented here:
>
https://developer.apple.com/library/safari/documentation/tools/conceptual/saf...
> 
> However, the code changed here just maps tag names to request types, which IMO
> is pretty obvious.

[Sebastian Noack, 2014-12-03 10:31:35]

Background images are neither considered for the standard "load" and "error"
events. So IMO its obvious that the "beforeload" event don't consider them as
well.

But even if it would consider them, it doesn't matter. If the background image
of an <input type=text> would be considered with the "beforeload" event (which
it's not), we recognize it with the type "image" which is perfectly fine.

[Wladimir Palant, 2014-12-03 13:49:41]

LGTM