Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5702539706105856: Issue 2444 - Make preconfigurable property optional (Closed)

Created:
May 4, 2015, 5:05 p.m. by Felix Dahlke
Modified:
May 4, 2015, 6:57 p.m.
Visibility:
Public.

Description

Issue 2444 - Make preconfigurable property optional

Patch Set 1 #

Patch Set 2 : Use a temp, more readable #

Patch Set 3 : Use a set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M lib/prefs.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
Felix Dahlke
Realised I forgot to test this without any preconfigurable properties (we'll have that in most ...
May 4, 2015, 5:05 p.m. (2015-05-04 17:05:56 UTC) #1
Sebastian Noack
LGTM
May 4, 2015, 5:10 p.m. (2015-05-04 17:10:48 UTC) #2
Felix Dahlke
Using a set now as suggested by Sebastian, surely the cleanest way. Tested it in ...
May 4, 2015, 5:37 p.m. (2015-05-04 17:37:01 UTC) #3
Sebastian Noack
Even more LGTM
May 4, 2015, 5:37 p.m. (2015-05-04 17:37:07 UTC) #4
Wladimir Palant
May 4, 2015, 6:49 p.m. (2015-05-04 18:49:06 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld