1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository

build.py

Index: build.py
===================================================================
--- a/build.py
+++ b/build.py
@@ -3,5 +3,14 @@
 
 import os, sys, subprocess
 
+DEPENDENCY_SCRIPT = os.path.join(os.path.dirname(__file__), "ensure_dependencies.py")
+
+if os.path.isfile(DEPENDENCY_SCRIPT):

[Sebastian Noack, 2015/01/13 17:21:53]

Why do you check whether the script exists? It's there. You are adding it with
the same patch.

[paco, 2015/01/14 11:40:49]

As requested by Wladimir, we should call the script only if the file actually
exists.

[Sebastian Noack, 2015/01/14 11:58:46]

I am not sure whether I agree. The only scenario where the script won't exist,
is if somebody (accidentally) deleted it. In that case I'd certainly prefer to
see an error, rather than silently ignoring it. I put Wladimir into CC. So maybe
he can give some background, why he thinks this check makes sense?

[Wladimir Palant, 2015/01/14 13:11:17]

The idea was actually that this build script is to be used everywhere unchanged
- yet some repositories might now have dependencies, so ensure_dependencies.py
won't exist. However, given that build.py itself depends on buildtools we can
probably ignore that scenario and just run ensure_dependencies.py
unconditionally.

[paco, 2015/01/14 16:00:36]

Will remove `if` in next patch

+  try:
+    subprocess.check_call(["python", DEPENDENCY_SCRIPT])
+  except subprocess.CalledProcessError as e:
+    print >>sys.stderr, e
+    print >>sys.stderr, "Failed to ensure dependencies being up-to-date!"
+
 import buildtools.build
 buildtools.build.processArgs('.', sys.argv)