Issue 309 - Don't use Shadow DOM in Chrome 32

Apparently there are some more builds between Chrome 32.0.1700 and 33 with broken <shadow> element.

[Thomas Greiner, 2014-04-17 15:55:57]

http://codereview.adblockplus.org/5715983079571456/diff/5629499534213120/incl...
File include.preload.js (right):

http://codereview.adblockplus.org/5715983079571456/diff/5629499534213120/incl...
include.preload.js:32: if ("webkitCreateShadowRoot" in document.documentElement
&& !(/\bChrome\/32\.0\.(\d+)\b/.test(navigator.userAgent) && RegExp.$1 >= 1700))
RegExp.$1 is deprecated (see
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Deprecated_and...)

http://codereview.adblockplus.org/5715983079571456/diff/5629499534213120/incl...
include.preload.js:32: if ("webkitCreateShadowRoot" in document.documentElement
&& !(/\bChrome\/32\.0\.(\d+)\b/.test(navigator.userAgent) && RegExp.$1 >= 1700))
The match that you get from the regular expression is a string so let's make
sure to compare two numbers by using parseInt(...).

[Sebastian Noack, 2014-04-17 16:16:35]

http://codereview.adblockplus.org/5715983079571456/diff/5629499534213120/incl...
File include.preload.js (right):

http://codereview.adblockplus.org/5715983079571456/diff/5629499534213120/incl...
include.preload.js:32: if ("webkitCreateShadowRoot" in document.documentElement
&& !(/\bChrome\/32\.0\.(\d+)\b/.test(navigator.userAgent) && RegExp.$1 >= 1700))
On 2014/04/17 15:55:57, Thomas Greiner wrote:
> RegExp.$1 is deprecated (see
>
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Deprecated_and...)

Done.

[Sebastian Noack, 2014-04-17 16:48:42]

Apparently there also older builds of Chrome 32 (e.g. 32.0.1690) that are
affected. It isn't probably worth to check every single build, also considering
that most users still on Chrome 32 are more likely to be on the higher ones,
which are affected anyway. So the new patch just checks for Chrome 32.*

[Thomas Greiner, 2014-04-17 17:39:00]

LGTM with the nit addressed

http://codereview.adblockplus.org/5715983079571456/diff/5724160613416960/incl...
File include.preload.js (right):

http://codereview.adblockplus.org/5715983079571456/diff/5724160613416960/incl...
include.preload.js:33: if ("webkitCreateShadowRoot" in document.documentElement
&& !((match = navigator.userAgent.match(/\bChrome\/32\.0\.(\d+)\b/)) &&
parseInt(match[1]) >= 1700))
Nit: That's an unnecessarily long line. You could for instance move the variable
initialization outside of the if-statement and break on each &&.

var match = navigator.userAgent.match(/\bChrome\/32\.0\.(\d+)\b/);
if ("webkitCreateShadowRoot" in document.documentElement
  && !((match && parseInt(match[1]) >= 1700))

[Sebastian Noack, 2014-04-17 17:56:45]

http://codereview.adblockplus.org/5715983079571456/diff/5724160613416960/incl...
File include.preload.js (right):

http://codereview.adblockplus.org/5715983079571456/diff/5724160613416960/incl...
include.preload.js:33: if ("webkitCreateShadowRoot" in document.documentElement
&& !((match = navigator.userAgent.match(/\bChrome\/32\.0\.(\d+)\b/)) &&
parseInt(match[1]) >= 1700))
On 2014/04/17 17:39:00, Thomas Greiner wrote:
> Nit: That's an unnecessarily long line. You could for instance move the
variable
> initialization outside of the if-statement and break on each &&.
> 
> var match = navigator.userAgent.match(/\bChrome\/32\.0\.(\d+)\b/);
> if ("webkitCreateShadowRoot" in document.documentElement
>   && !((match && parseInt(match[1]) >= 1700))

The reason I did it that way is, is to don't execute the regex if Shadow DOM
isn't supported. However that variable is gone anyway, in the new patch set.

[Thomas Greiner, 2014-04-22 09:47:04]

LGTM

http://codereview.adblockplus.org/5715983079571456/diff/5717271485874176/incl...
File include.preload.js (right):

http://codereview.adblockplus.org/5715983079571456/diff/5717271485874176/incl...
include.preload.js:31: // the <shadow> element is broken in some Chrome 32
builts (#309)
Nit: Correct "builts" to "builds"