Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5719138018263040: Better way to set PATH_INFO variable for Trac (Closed)

Created:
March 11, 2014, 12:07 p.m. by Wladimir Palant
Modified:
March 13, 2014, 9:15 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Better way to set PATH_INFO variable for Trac

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed unnecessary assignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M modules/trac/templates/site.erb View 1 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
March 11, 2014, 12:07 p.m. (2014-03-11 12:07:04 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/5719138018263040/diff/5629499534213120/modules/trac/templates/site.erb File modules/trac/templates/site.erb (right): http://codereview.adblockplus.org/5719138018263040/diff/5629499534213120/modules/trac/templates/site.erb#newcode36 modules/trac/templates/site.erb:36: fastcgi_split_path_info ^()(.*)$; I assume you tested it, but based ...
March 13, 2014, 12:37 a.m. (2014-03-13 00:37:53 UTC) #2
Wladimir Palant
Removed unnecessary assignment
March 13, 2014, 6:50 a.m. (2014-03-13 06:50:28 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5719138018263040/diff/5629499534213120/modules/trac/templates/site.erb File modules/trac/templates/site.erb (right): http://codereview.adblockplus.org/5719138018263040/diff/5629499534213120/modules/trac/templates/site.erb#newcode36 modules/trac/templates/site.erb:36: fastcgi_split_path_info ^()(.*)$; On 2014/03/13 00:37:53, Felix H. Dahlke wrote: ...
March 13, 2014, 6:50 a.m. (2014-03-13 06:50:40 UTC) #4
Felix Dahlke
March 13, 2014, 8:06 a.m. (2014-03-13 08:06:45 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld