Better way to set PATH_INFO variable for Trac

modules/trac/templates/site.erb

Index: modules/trac/templates/site.erb
===================================================================
--- a/modules/trac/templates/site.erb
+++ b/modules/trac/templates/site.erb
@@ -27,25 +27,20 @@ server {
 
   ssl_certificate adblockplus.org_sslcert.pem;
   ssl_certificate_key adblockplus.org_sslcert.key;
 
   add_header Strict-Transport-Security max-age=31536000;
 
   location /
   {
-    set $path_info $request_uri;
-    if ($path_info ~ "(.*?)\?")
-    {
-      set $path_info $1;
-    }
-
     fastcgi_pass unix:/tmp/trac-fastcgi.sock;
+    fastcgi_split_path_info ^()(.*)$;

[Felix Dahlke, 2014/03/13 00:37:53]

I assume you tested it, but based on the docs it sounds like we'd still need to
stop matching at the first occurrence of a ?. I guess that's not the case?

[Wladimir Palant, 2014/03/13 06:50:41]

Not sure where you've got it from, the docs quite clearly speak about splitting
the path into two parts and the example regexp matches to the end of the string.

But - sure, this works fine with query strings.

     include /etc/nginx/fastcgi_params;
     fastcgi_param SCRIPT_NAME "";

[Felix Dahlke, 2014/03/13 00:37:53]

Is this still necessary? Seems to me as if fastcgi_split_path_info should set
fastcgi_script_name to an empty string.

[Wladimir Palant, 2014/03/13 06:50:41]

You are right, this is unnecessary now.

-    fastcgi_param PATH_INFO $path_info;
+    fastcgi_param PATH_INFO $fastcgi_path_info;
   }
 
   location /chrome/
   {
     alias /home/trac/htdocs/htdocs/;
   }
 }