safari/ext/background.js - Issue 5721433737003008: Issue 1985 - Replaced __proto__ with Object.create() and Object.getPrototypeOf()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: safari/ext/background.js

Issue 5721433737003008: Issue 1985 - Replaced __proto__ with Object.create() and Object.getPrototypeOf() (Closed)

Patch Set: Created Feb. 11, 2015, 11:51 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: safari/ext/background.js

===================================================================

--- a/safari/ext/background.js

+++ b/safari/ext/background.js

@@ -19,7 +19,7 @@

{

/* Pages */

- var pages = {__proto__: null};

+ var pages = Object.create(null);

var pageCounter = 0;

var Page = function(id, tab, url)

@@ -501,8 +501,9 @@

};

});

- if (obj.__proto__)

- objectInfo.prototypeId = this.registerObject(obj.__proto__, objects);

+ var proto = Object.getPrototypeOf(obj);

+ if (proto)

+ objectInfo.prototypeId = this.registerObject(proto, objects);

if (obj == Object.prototype)

objectInfo.prototypeOf = "Object";

@@ -537,7 +538,7 @@

frameId = 0;

if (!('_pages' in tab))

- tab._pages = {__proto__: null};

+ tab._pages = Object.create(null);

var page = new Page(pageId, tab, message.url);

pages[pageId] = tab._pages[pageId] = page;

« no previous file with comments | « qunit/common.js ('k') | safari/ext/common.js » ('j') | no next file with comments »