qunit/common.js - Issue 5721433737003008: Issue 1985 - Replaced __proto__ with Object.create() and Object.getPrototypeOf()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: qunit/common.js

Issue 5721433737003008: Issue 1985 - Replaced __proto__ with Object.create() and Object.getPrototypeOf() (Closed)

Patch Set: Created Feb. 11, 2015, 11:51 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: qunit/common.js

===================================================================

--- a/qunit/common.js

+++ b/qunit/common.js

@@ -28,9 +28,9 @@

function prepareFilterComponents(keepListeners)

{

FilterStorage.subscriptions = [];

- FilterStorage.knownSubscriptions = {__proto__: null};

- Subscription.knownSubscriptions = {__proto__: null};

- Filter.knownFilters = {__proto__: null};

+ FilterStorage.knownSubscriptions = Object.create(null);

+ Subscription.knownSubscriptions = Object.create(null);

+ Filter.knownFilters = Object.create(null);

defaultMatcher.clear();

ElemHide.clear();

@@ -42,7 +42,7 @@

function preparePrefs()

{

- this._pbackup = {__proto__: null};

+ this._pbackup = Object.create(null);

for (var pref in Prefs)

if (Prefs.__lookupSetter__(pref))

this._pbackup[pref] = Prefs[pref];

« no previous file with comments | « options.js ('k') | safari/ext/background.js » ('j') | no next file with comments »