Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5723943474298880: Change the default bookmarks (Closed)

Created:
Dec. 24, 2014, 12:26 p.m. by Felix Dahlke
Modified:
May 21, 2015, 11:52 a.m.
Visibility:
Public.

Description

Change the default bookmarks Using the icons previously used for Firefox Marketplace and support for now.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Repurpose default bookmark icons #

Messages

Total messages: 6
Felix Dahlke
Dec. 24, 2014, 12:45 p.m. (2014-12-24 12:45:48 UTC) #1
René Jeschke
http://codereview.adblockplus.org/5723943474298880/diff/5629499534213120/mobile/android/base/strings.xml.in File mobile/android/base/strings.xml.in (right): http://codereview.adblockplus.org/5723943474298880/diff/5629499534213120/mobile/android/base/strings.xml.in#newcode372 mobile/android/base/strings.xml.in:372: <!-- Icon is automatically generated from R.drawable.bookmarkdefaults_favicon_adblockplus --> What ...
Jan. 26, 2015, 11:05 a.m. (2015-01-26 11:05:10 UTC) #2
Felix Dahlke
Repurpose default bookmark icons
Feb. 5, 2015, 6:34 a.m. (2015-02-05 06:34:30 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/5723943474298880/diff/5629499534213120/mobile/android/base/strings.xml.in File mobile/android/base/strings.xml.in (right): http://codereview.adblockplus.org/5723943474298880/diff/5629499534213120/mobile/android/base/strings.xml.in#newcode372 mobile/android/base/strings.xml.in:372: <!-- Icon is automatically generated from R.drawable.bookmarkdefaults_favicon_adblockplus --> On ...
Feb. 5, 2015, 6:35 a.m. (2015-02-05 06:35:46 UTC) #4
René Jeschke
LGTM
Feb. 18, 2015, 2:53 p.m. (2015-02-18 14:53:17 UTC) #5
Wladimir Palant
Feb. 18, 2015, 5:57 p.m. (2015-02-18 17:57:33 UTC) #6
LGTM - but please don't forget to replace these icons by the real ones.

Powered by Google App Engine
This is Rietveld