Issue 926 - Filters should not be applied on local pages

webrequest.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 31 matching lines @@
   {
     // Execute delayed to prevent multiple executions in a quick succession
     if (onFilterChangeTimeout != null)
       window.clearTimeout(onFilterChangeTimeout);
     onFilterChangeTimeout = window.setTimeout(onFilterChange, 2000);
   }
 });
 
 function onBeforeRequest(url, type, page, frame)
 {
-  if (!/^https?:/.test(url) || isFrameWhitelisted(page, frame))

[Sebastian Noack, 2014/07/15 22:47:44]

Any reasons that you don't just change the url pattern, when registering the
onBeforeRequest handler?

chrome.webRequest.onBeforeRequest.addListener(function(details) { ... }, {urls:
["http://*", "https://*"]}, ["blocking"]);

[Wladimir Palant, 2014/07/16 07:12:29]

Changing this in chrome/ext/background.js seems to be a better solution indeed.
I verified that Safari won't send any non-HTTP URLs (there is a URL check in the
beforeload handler in safari/ext/content.js) so this is indeed only an issue
with Chrome's abstraction layer.

+  if (isFrameWhitelisted(page, frame))
     return true;
 
   var docDomain = extractHostFromFrame(frame);
   var filter = defaultMatcher.matchesAny(
     url,
     type == "sub_frame" ? "SUBDOCUMENT" : type.toUpperCase(),
     docDomain,
     isThirdParty(extractHostFromURL(url), docDomain)
   );
 
@@ skipping 33 matching lines @@
       var header = details.responseHeaders[i];
       if (header.name.toLowerCase() == "x-adblock-key" && header.value)
         processKeyException(header.value, page, frame);
     }
 
     var notificationToShow = Notification.getNextToShow(details.url);
     if (notificationToShow)
       showNotification(notificationToShow);
   }
 
-  chrome.webRequest.onHeadersReceived.addListener(onHeadersReceived, {urls: ["<all_urls>"]}, ["responseHeaders"]);
+  chrome.webRequest.onHeadersReceived.addListener(onHeadersReceived, {urls: ["http://*/*", "https://*/*"]}, ["responseHeaders"]);
 }