Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5728050318671872: Issue 926 - Filters should not be applied on local pages (Closed)

Created:
July 15, 2014, 12:04 p.m. by Thomas Greiner
Modified:
July 16, 2014, 3:10 p.m.
Visibility:
Public.

Description

Issue 926 - Filters should not be applied on local pages

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/ext/background.js View 1 1 chunk +1 line, -1 line 0 comments Download
M webrequest.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Thomas Greiner
July 15, 2014, 12:07 p.m. (2014-07-15 12:07:36 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5728050318671872/diff/5629499534213120/webrequest.js File webrequest.js (right): http://codereview.adblockplus.org/5728050318671872/diff/5629499534213120/webrequest.js#newcode52 webrequest.js:52: if (!/^https?:/.test(url) || isFrameWhitelisted(page, frame)) Any reasons that you ...
July 15, 2014, 10:47 p.m. (2014-07-15 22:47:44 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/5728050318671872/diff/5629499534213120/webrequest.js File webrequest.js (right): http://codereview.adblockplus.org/5728050318671872/diff/5629499534213120/webrequest.js#newcode52 webrequest.js:52: if (!/^https?:/.test(url) || isFrameWhitelisted(page, frame)) On 2014/07/15 22:47:44, Sebastian ...
July 16, 2014, 7:12 a.m. (2014-07-16 07:12:29 UTC) #3
Thomas Greiner
If Safari is unproblematic then Chromium-only it shall be. I also changed it for onHeadersReceived ...
July 16, 2014, 9:13 a.m. (2014-07-16 09:13:55 UTC) #4
Wladimir Palant
LGTM
July 16, 2014, 10:44 a.m. (2014-07-16 10:44:56 UTC) #5
Sebastian Noack
July 16, 2014, 3:10 p.m. (2014-07-16 15:10:47 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld