Issue 151 - [Typed objects] Implement dynamically-sized array types

lib/typedObjects/utils.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 115 matching lines @@
 
 /**
  * Defines properties with given name and type on an object.
  *
  * @param obj object to define properties on
  * @param properties object mapping property names to their respective types
  * @param viewTypes see getViewsForType()
  * @param views see getViewsForType()
  * @param [offset] byte array offset at which the properties should start
  * @param [watchers] map of watcher functions to be called when a particular property is being set
- * @param [cleanupValues] array of property/value combinations to be set when the object is created or destroyed
+ * @param [initialValues] array of property/value combinations to be set when the object is created or destroyed
  * @return new start offset for additional properties
  */
-exports.defineProperties = function defineProperties(obj, properties, viewTypes, views, offset, watchers, cleanupValues)
+exports.defineProperties = function defineProperties(obj, properties, viewTypes, views, offset, watchers, initialValues)
 {
   offset = offset | 0;
 
   let propList = [];
   for (let name in properties)
     propList.push([name, properties[name]]);
 
   // Put larger properties first to make sure alignment requirements are met.
   propList.sort(function(a, b)
   {
@@ skipping 11 matching lines @@
       get: wrapGetter(type.createGetter.apply(type, [offset].concat(viewParams))),
       set: wrapSetter(type.createSetter.apply(type, [offset].concat(viewParams))),
       configurable: false,
       enumerable: true
     };
 
     if (watchers && typeof watchers[name] == "function")
       descriptors[name].set = watchSetter(descriptors[name].set, watchers[name]);
 
     offset += type.referenceLength;
-    if (cleanupValues && typeof type.cleanupValue != "undefined")
-      cleanupValues.push([name, type.cleanupValue]);
+    if (initialValues && typeof type.initialValue != "undefined")
+      initialValues.push([name, type.initialValue]);
   }
 
   // Define properties
   Object.defineProperties(obj, descriptors);
 
   return offset;
 };
 
 /**
  * Creates a new array buffer and adds the necessary views.
@@ skipping 85 matching lines @@
 exports.dealloc = function(firstFree, bufferIndex, byteOffset)
 {
   let oldFreeBufferIndex = firstFree.bufferIndex | 0;
   let oldFreeByteOffset = firstFree.byteOffset | 0;
 
   firstFree.bufferIndex = bufferIndex | 0;
   firstFree.byteOffset = byteOffset | 0;
   firstFree.targetBufferIndex = oldFreeBufferIndex;
   firstFree.targetByteOffset = oldFreeByteOffset;
 }