Issue 151 - [Typed objects] Implement dynamically-sized array types

Issue 151 - [Typed objects] Implement dynamically-sized array types

[Wladimir Palant, 2014-05-16 13:23:14]

http://codereview.adblockplus.org/5728072976302080/diff/5629499534213120/test...
File test/tests/typedObjects.js (right):

http://codereview.adblockplus.org/5728072976302080/diff/5629499534213120/test...
test/tests/typedObjects.js:679: for (let array of [array1, array2, array3,
array4])
This should release array5 as well, fixed it locally.

[Wladimir Palant, 2014-05-19 07:58:34]

http://codereview.adblockplus.org/5728072976302080/diff/5629499534213120/lib/...
File lib/typedObjects/arrayTypes.js (right):

http://codereview.adblockplus.org/5728072976302080/diff/5629499534213120/lib/...
lib/typedObjects/arrayTypes.js:168: let dst = Uint8Array(buffers[bufferIndex],
byteOffset, copyBytes);
Chrome and Safari complained about Uint8Array being used as a function, Firefox
is apparently more forgiving here.

[René Jeschke, 2014-05-20 16:58:51]

This LGTM, but there are two naming issues (which are both not really a
must-fix):

1. 'cleanupValue' -> I think this one would be better called 'initialValue' as
this more accurately describes what it does.

2. The whole 'watcher' stuff. I'm not quite satisfied with calling it 'watcher'.
'observer' would maybe be a better name for this, but there are also the
getter/setter wrappers that are also called watchers for which 'observer' won't
be the correct name.

So this issue affects two groups of functions:
1. the 'watch' meta data which assigns functions to properties and 'transform' a
value
2. the size/length-Watchers which could be renamed to 'observers' 

Maybe fhd or tschuster have an idea on the naming issue for the 'watchers'?

[Felix Dahlke, 2014-05-21 07:21:17]

On 2014/05/20 16:58:51, René Jeschke wrote:
> This LGTM, but there are two naming issues (which are both not really a
> must-fix):
> 
> 1. 'cleanupValue' -> I think this one would be better called 'initialValue' as
> this more accurately describes what it does.
> 
> 2. The whole 'watcher' stuff. I'm not quite satisfied with calling it
'watcher'.
> 'observer' would maybe be a better name for this, but there are also the
> getter/setter wrappers that are also called watchers for which 'observer'
won't
> be the correct name.
> 
> So this issue affects two groups of functions:
> 1. the 'watch' meta data which assigns functions to properties and 'transform'
a
> value
> 2. the size/length-Watchers which could be renamed to 'observers' 
> 
> Maybe fhd or tschuster have an idea on the naming issue for the 'watchers'?

It seems to me like the size/length watchers are the same as the other property
watchers, can you elaborate on how they differ?

But I don't really like the term "watcher" either, since they actually modify
the thing they watch. Maybe "advice" (from AOP) would be a more fitting term?

[Wladimir Palant, 2014-05-21 07:27:54]

On 2014/05/21 07:21:17, Felix H. Dahlke wrote:
> But I don't really like the term "watcher" either, since they actually modify
> the thing they watch. Maybe "advice" (from AOP) would be a more fitting term?

The term "watcher" comes from the Object.watch() method in SpiderMonkey
providing similar functionality. I don't really see a better name for it so we
might just as well keep it.

[Wladimir Palant, 2014-07-11 07:28:53]

I renamed cleanupValue into initialValue. The new patchset also fixes a few
other minor issues. The watchers are still called like that given that Mozilla
uses this terminology and nobody can suggest a better term.

[René Jeschke, 2014-07-11 07:33:34]

On 2014/07/11 07:28:53, Wladimir Palant wrote:
> I renamed cleanupValue into initialValue. The new patchset also fixes a few
> other minor issues. The watchers are still called like that given that Mozilla
> uses this terminology and nobody can suggest a better term.

Fair enough. Checked the fixes. 
LGTM